Repository navigation
Interface based approach #19
Description
We should consider offering interfaces for to allow third-party implementations and allow custom sinks. This issue can serve as umbrella for proposals / thoughts.
This issue was initially raised on the mailing list https://groups.google.com/d/msg/kubernetes-sig-architecture/wCWiWf3Juzs/nLtAC41tCwAJ.
Activity
dims commentedon Nov 15, 2018
cc @munnerz
munnerz commentedon Nov 15, 2018
I got started on adding a SetLogger function as a PoC for this after talking with @dims earlier in #20.
The PR is focused around
github.com/go-logr/log, and behaves similarly toklog.SetOutput.I couldn't work out a way to avoid changing the public facing API for the
Verbosetype however, without creating distinct types for each V level (which would mean we couldn't support arbitrary V levels).Keen to hear thoughts on the implementation/design. It seems useful to have something like this whilst kubernetes itself doesn't support a more structured log format/is still transitioning to whatever log package comes next.
fejta-bot commentedon Feb 13, 2019
Issues go stale after 90d of inactivity.
Mark the issue as fresh with
/remove-lifecycle stale.Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with
/close.Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
fejta-bot commentedon Mar 15, 2019
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with
/remove-lifecycle rotten.Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with
/close.Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
detiber commentedon Mar 15, 2019
/remove-lifecycle rotten
DirectXMan12 commentedon Mar 15, 2019
I'm not convinced we need this any more. We now have support for klog as a logr backend, and vice-versa should be merging soon.
vincepri commentedon Mar 15, 2019
Agreed, this probably can be closed.
detiber commentedon Mar 15, 2019
/close
k8s-ci-robot commentedon Mar 15, 2019
@detiber: Closing this issue.
Details
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.