Repository navigation
Fix default annotation to match JSON property names - #601
Merged
k8s-ci-robot merged 1 commit intoMay 7, 2026
Merged
k8s-ci-robot merged 1 commit into
k8s-ci-robot merged 1 commit into
Conversation
The SubStruct fields serialize as "S" and "I" in JSON, but the +default annotation used lowercase "s" and "i". Signed-off-by: Arthur Diniz <arthurbdiniz@gmail.com>
k8s-ci-robot
added
size/S
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arthurbdiniz, Jefftree The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
SubStructfields serialize as"S"and"I"in JSON (field nameShas no json tag, fieldIhasjson:"I,omitempty"), but the+defaultannotation used lowercase"s"and"i".kube-openapi/test/integration/testdata/defaults/default.go
Line 39 in 3334182
This caused the generated OpenAPI spec to advertise a default value with keys that don't correspond to the actual schema property names, producing an invalid default.
This PR updates the
+defaultannotation to{"S": "foo", "I": 5}and regenerates the affected golden files.