Skip to content

Localize some pages into Ukrainian - #45382

Closed
sftim wants to merge 9 commits into
kubernetes:mainfrom
sftim:20240227_improve_uk_filtered_2
Closed

sftim wants to merge 9 commits into
kubernetes:mainfrom
sftim:20240227_improve_uk_filtered_2

Conversation

@sftim

@sftim sftim commented Feb 28, 2024

Copy link
Copy Markdown
Contributor

Work by @Andygol; I'm submitting a subset of the commits available in https://github.com/Andygol/k8s-website

Andygol and others added 9 commits February 28, 2024 16:22
Co-Authored-By: Tim Bannister <tim@scalefactory.com>
Co-Authored-By: Tim Bannister <tim@scalefactory.com>
…ions, stateless applications, and security. Update titles and weights for existing tutorial pages.
Co-authored-by: Andrii Holovin <Andygol@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 28, 2024
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from sftim. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/uk Issues or PRs related to Ukrainian language label Feb 28, 2024
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Feb 28, 2024
@netlify

netlify Bot commented Feb 28, 2024

Copy link
Copy Markdown

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit a7e1143
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65df9b62c8bc6a0008ba14ea
😎 Deploy Preview https://deploy-preview-45382--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@divya-mohan0209

Copy link
Copy Markdown
Contributor

The PR is massive from a reviewing/approving perspective. Following the precedent set by @natalisucks's comment in #45371, please break this into smaller chunks for ease of review.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 30, 2024
@sftim

sftim commented Apr 2, 2024

Copy link
Copy Markdown
Contributor Author

@Andygol - would you be willing to open PRs that contain chunks of the work you've done in your own fork? You could base them on this PR if that's helpful.

@Andygol

Andygol commented Apr 3, 2024

Copy link
Copy Markdown
Contributor

@sftim thank you for your attempt to help with the publication of the Ukrainian translation. It would be really cool if the pilot #45756 was based on my translation fork (https://github.com/Andygol/k8s-website/tree/main-uk-wip), it could solve the current problems with review and splitting the translation into separate parts.

@sftim

sftim commented Apr 3, 2024

Copy link
Copy Markdown
Contributor Author

We'll base the pilot on this repository, https://github.com/kubernetes/website

@sftim
sftim marked this pull request as draft April 13, 2024 16:46
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 13, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 23, 2024
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-triage-robot

Copy link
Copy Markdown

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 22, 2024
@k8s-triage-robot

Copy link
Copy Markdown

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 21, 2024
@k8s-ci-robot k8s-ci-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Sep 21, 2024
@sftim

sftim commented Oct 3, 2024

Copy link
Copy Markdown
Contributor Author

/close

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

@sftim: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sftim

sftim commented Oct 3, 2024

Copy link
Copy Markdown
Contributor Author

@sftim thank you for your attempt to help with the publication of the Ukrainian translation. It would be really cool if the pilot #45756 was based on my translation fork (https://github.com/Andygol/k8s-website/tree/main-uk-wip), it could solve the current problems with review and splitting the translation into separate parts.

@Andygol if you send in your contributions via a PR - even a massive one that we can't merge - and you confirm your willingness to license the localization via your existing CLA, we can adapt the work you've done.

If you don't confer that agreement, we can't use it. So we'd really like to have it via a PR.

Ideally small merge-able PRs, but failing that one big one is still helpful.

@sftim
sftim deleted the 20240227_improve_uk_filtered_2 branch March 22, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/uk Issues or PRs related to Ukrainian language lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants