Skip to content

[uk] Localize community section - #48559

Closed
sftim wants to merge 2 commits into
kubernetes:mainfrom
sftim:20241027_uk_community
Closed

sftim wants to merge 2 commits into
kubernetes:mainfrom
sftim:20241027_uk_community

Conversation

@sftim

@sftim sftim commented Oct 27, 2024 •

Copy link
Copy Markdown
Contributor

Split out from PR #48551 (by @Andygol)

/language uk

Add Ukrainian localization of https://kubernetes.io/community/ (and contents)

preview

@k8s-ci-robot k8s-ci-robot added the language/uk Issues or PRs related to Ukrainian language label Oct 27, 2024
@k8s-ci-robot
k8s-ci-robot requested a review from Arhell October 27, 2024 16:07
@k8s-ci-robot k8s-ci-robot added the area/localization General issues or PRs related to localization label Oct 27, 2024
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 27, 2024
[Кодексу поведінки CNCF](https://github.com/cncf/foundation/blob/main/code-of-conduct.md). Текст Кодексу поведінки CNCF відтворено нижче, [коміт 71412bb02](https://github.com/cncf/foundation/blob/71412bb029090d42ecbeadb39374a337bfb48a9c/code-of-conduct.md)._

<div id="cncf-code-of-conduct">
{{< include "static/cncf-code-of-conduct.md" >}}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build preview has failed with the following error (logs here):

ERROR [uk] the 'includes' bundle was not found.

I think the error might be due to a missing / in the file path.

Suggested change
{{< include "static/cncf-code-of-conduct.md" >}}
{{< include "/static/cncf-code-of-conduct.md" >}}

@Andygol Andygol Oct 28, 2024 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dipesh-rawat thanks for your suggestion, but I don't think that it was correct. The folder content/uk/community has the same structure as content/en/community.

The issue is required further investigation.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difference is that uk/community/static folder contains only one (translated) file

👇 en/community/static looks like this
image

Comment thread content/uk/community/_index.html Resolved
@sftim
sftim marked this pull request as draft October 29, 2024 09:24
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 29, 2024
@k8s-triage-robot

Copy link
Copy Markdown

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 27, 2025
@sftim
sftim force-pushed the 20241027_uk_community branch from 646b364 to 9f2e460 Compare February 23, 2025 23:47
@sftim

sftim commented Feb 23, 2025

Copy link
Copy Markdown
Contributor Author

Think I found the problem: you can't use the include shortcode unless there is an includes/index.html for that localization.

@sftim
sftim marked this pull request as ready for review February 23, 2025 23:48
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 23, 2025
@netlify

netlify Bot commented Feb 23, 2025 •

Copy link
Copy Markdown

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 93084a1
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/683c5122f92cb00008bbe042
😎 Deploy Preview https://deploy-preview-48559--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Largely the work of its co-author.

Co-authored-by: Andrii Holovin <Andygol@users.noreply.github.com>
@sftim
sftim force-pushed the 20241027_uk_community branch from 6001c8b to 127c236 Compare February 24, 2025 10:00
@sftim

sftim commented Feb 27, 2025

Copy link
Copy Markdown
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 27, 2025
Comment thread content/uk/community/_index.html Resolved
Comment thread content/uk/community/_index.html Resolved
Comment thread content/uk/community/code-of-conduct.md Resolved

@lmktfy lmktfy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Borrowing suggestions

Comment thread content/uk/community/_index.html Resolved
Comment thread content/uk/community/_index.html Resolved
Comment thread content/uk/community/code-of-conduct.md Resolved
@linux-foundation-easycla

Copy link
Copy Markdown

CLA Missing ID CLA Not Signed

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign maxymvlasov for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 1, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 1, 2025
@lmktfy

lmktfy commented Jun 1, 2025

Copy link
Copy Markdown
Member

/close

In favor of PR #51149

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

@lmktfy: Closed this PR.

Details

In response to this:

/close

In favor of PR #51149

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/localization General issues or PRs related to localization cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. language/uk Issues or PRs related to Ukrainian language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants