Skip to content

Serve example manifests in KYAML and YAML - #56971

Closed
TineoC wants to merge 1 commit into
kubernetes:dev-1.38from
TineoC:kyaml/dual-render-silent
Closed

TineoC wants to merge 1 commit into
kubernetes:dev-1.38from
TineoC:kyaml/dual-render-silent

Conversation

@TineoC

@TineoC TineoC commented Aug 13, 2026 •

Copy link
Copy Markdown
Contributor

Part of #57030, per KEP-5295.

make kyaml renders listed manifests into
content/<lang>/examples-kyaml/ with the pinned yamlfmt from sigs.k8s.io/yaml.
make verify-kyaml fails if stale.

Pages to Test

This PR was written in part with the assistance of generative AI.

/sig docs
/language en

@kubernetes-prow kubernetes-prow Bot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. language/en Issues or PRs related to English language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes labels Aug 13, 2026
@netlify

netlify Bot commented Aug 13, 2026 •

Copy link
Copy Markdown

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit dbb69f3
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/6ace41bee070d6621a668686
😎 Deploy Preview https://deploy-preview-56971--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@TineoC
TineoC marked this pull request as draft August 14, 2026 12:16
@kubernetes-prow kubernetes-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 14, 2026
@TineoC
TineoC force-pushed the kyaml/dual-render-silent branch from a4a3848 to 21c43fd Compare August 17, 2026 00:16
@kubernetes-prow kubernetes-prow Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 17, 2026
@TineoC TineoC changed the title Render every example manifest as KYAML, behind a hidden switch Render four example manifests as KYAML, behind a hidden control Aug 17, 2026
@TineoC
TineoC force-pushed the kyaml/dual-render-silent branch from 21c43fd to 6276200 Compare August 17, 2026 00:21
@TineoC TineoC changed the title Render four example manifests as KYAML, behind a hidden control Offer four example manifests as KYAML as well as conventional YAML Aug 17, 2026
@TineoC TineoC changed the title Offer four example manifests as KYAML as well as conventional YAML Serve example manifests in KYAML and YAML Aug 17, 2026
@TineoC
TineoC force-pushed the kyaml/dual-render-silent branch 3 times, most recently from 179d8c0 to d9e3264 Compare August 17, 2026 21:33
@linux-foundation-easycla

linux-foundation-easycla Bot commented Aug 17, 2026 •

Copy link
Copy Markdown

CLA Missing ID

  • ✅ login: TineoC / name: Christopher Tineo (dbb69f3)
  • ❌ The email address for the commit (dbb69f3) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please visit our EasyCLA portal and chat with our support bot.

One or more co-authors of this pull request were not found. You must specify co-authors in commit message trailer via:

Co-authored-by: name <email>

Supported Co-authored-by: formats include:

  1. Anything <id+login@users.noreply.github.com> - it will locate your GitHub user by id part.
  2. Anything <login@users.noreply.github.com> - it will locate your GitHub user by login part.
  3. Anything <public-email> - it will locate your GitHub user by public-email part. Note that this email must be made public on Github.
  4. Anything <other-email> - it will locate your GitHub user by other-email part but only if that email was used before for any other CLA as a main commit author.
  5. login <any-valid-email> - it will locate your GitHub user by login part, note that login part must be at least 3 characters long.

Alternatively, if the co-author should not be included, remove the Co-authored-by: line from the commit message.

Please update your commit message(s) by doing git commit --amend and then git push [--force] and then request re-running CLA check via commenting on this pull request:

/easycla

@kubernetes-prow kubernetes-prow Bot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 17, 2026
@rxinui

rxinui commented Aug 18, 2026

Copy link
Copy Markdown
Member

I would like to involve @soltysh on that PR.

As mentioned on #56915 (comment), this addition could streamline the conversion of every example to KYAML. Probably the challenge would be the maintenance or usage of the script.

@TineoC
TineoC force-pushed the kyaml/dual-render-silent branch from 81042fd to 2035939 Compare August 18, 2026 18:24
@TineoC

TineoC commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

/easycla

@soltysh

soltysh commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Quickly dropping a few notes from today's SIG-Docs call, where we discussed this topic.

  1. We don't want to rush in with this PR, rather we want to focus on having long-term, easy solution to maintain yaml/kyaml and maybe json formats in the listings.
  2. From the call there was a suggestion that hugo/docsy supports mechanism for switching listings, which I believe this PR is implementing from scratch. @TineoC it would be good to look into that mechanism and replace that part of your PR with that built-in mechanism instead.
  3. The initial PR (this), should focus on the switch mechanism, as well as providing steps how to convert to other formats. The make kyaml is a good example of that.
  4. Once we land the initial PR, we'll be able to focus on introducing the remaining files. Whether that'll be a single PR, or a set of PRs is irrelevant.
  5. Lastly, we can introduce a checker, to ensure that every listing has all the available formats as a pre-submit job.

@TineoC

TineoC commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @soltysh for the comments

@TineoC
TineoC force-pushed the kyaml/dual-render-silent branch 2 times, most recently from 1511152 to c87f65a Compare August 18, 2026 20:23
@lmktfy

lmktfy commented Oct 10, 2026

Copy link
Copy Markdown
Member

@TineoC, would you be willing to update this PR so that it's ready to review?

If you'd prefer, you could target the dev-1.38 branch. Your choice (to be confirmed by SIG leadership) whether to land this change as part of 1.38 or via continuous publishing of main.

@TineoC
TineoC changed the base branch from main to dev-1.38 October 10, 2026 17:37
@TineoC
TineoC force-pushed the kyaml/dual-render-silent branch from 91949c9 to d52de02 Compare October 10, 2026 17:42
@TineoC

TineoC commented Oct 10, 2026

Copy link
Copy Markdown
Contributor Author
image https://deploy-preview-56971--kubernetes-io-main-staging.netlify.app/docs/concepts/workloads/pods/

@TineoC

TineoC commented Oct 10, 2026

Copy link
Copy Markdown
Contributor Author

@TineoC, would you be willing to update this PR so that it's ready to review?

If you'd prefer, you could target the dev-1.38 branch. Your choice (to be confirmed by SIG leadership) is whether to land this change as part of 1.38 or via continuous publishing of main.

I'm sorry for the delay.

I'm open to bringing this up to the next SIG Docs meeting and waiting for leadership to share their thoughts on whether they'd like to move forward with the change.

The preview pages are functional in Desktop and Mobile, so you can review the code and leave your thoughts in the Implementation @lmktfy.

/hold

@kubernetes-prow kubernetes-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2026
@TineoC
TineoC force-pushed the kyaml/dual-render-silent branch from d52de02 to d0e96fb Compare October 10, 2026 18:03
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@TineoC TineoC closed this Oct 13, 2026
@TineoC
TineoC force-pushed the kyaml/dual-render-silent branch from d0e96fb to dbb69f3 Compare October 13, 2026 14:35
@kubernetes-prow kubernetes-prow Bot added area/blog Issues or PRs related to the Kubernetes Blog subproject area/localization General issues or PRs related to localization kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. kind/support Categorizes issue or PR as a support question. language/bn Issues or PRs related to Bengali language language/de Issues or PRs related to German language and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 13, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign katcosgrove for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 13, 2026
@TineoC

TineoC commented Oct 13, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #58042. This PR was closed by an accidental force-push of a parentless commit and GitHub cannot reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/blog Issues or PRs related to the Kubernetes Blog subproject area/localization General issues or PRs related to localization area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. kind/support Categorizes issue or PR as a support question. language/bn Issues or PRs related to Bengali language language/de Issues or PRs related to German language language/en Issues or PRs related to English language sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants