Repository navigation
[uk] Fix cloud-controller link target and update nginx Deployment example - #59082
Merged
Merged
Conversation
…mple Follow the English link fix in the cloud-controller page and bring the Ukrainian copy of the nginx Deployment example in line with English (image `nginx:1.14.2`). Co-authored-by: Andrii Holovin <Andygol@users.noreply.github.com>
kubernetes-prow
Bot
added
the
area/localization
kubernetes-prow
Bot
added
cncf-cla: yes
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
kubernetes-prow
Bot
added
the
lgtm
Contributor
|
LGTM label has been added. DetailsGit tree hash: 173fc5e5162d544cd6abbb0a75bf3d0aff565df7 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Arhell The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings two Ukrainian files in line with the current English ones:
docs/concepts/architecture/cloud-controller.md: the Cloud Controller Manager Administration link anchor is#running-cloud-controller-manager, as fixed in English (6a9c1aa) after the uk page was last updatedexamples/controllers/nginx-deployment.yaml: the Ukrainian copy still usednginx:1.7.9; the example has no comments to translate, so it is now identical to the English file (nginx:1.14.2). The updated copy in 🇺🇦 Ukrainian localization of Kubernetes documentation #48551 has the same change.Co-authored-by: Andrii Holovin (@Andygol)