Repository navigation
Conversation
This commit brings the cgroup driver detection docs in line with the code. Since v1.34 the kubelet detects the cgroup driver from any container runtime that implements the RuntimeConfig CRI RPC. The `KubeletCgroupDriverFromCRI` feature gate is GA and locked on (KEP-4033).
kubernetes-prow
Bot
added
the
sig/node
github-project-automation
Bot
moved this to Triage
in SIG Node: code and documentation PRs
kubernetes-prow
Bot
added
cncf-cla: yes
kubernetes-prow
Bot
added
the
language/en
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Goal: Bring the docs in line with the code.
Since v1.34 the kubelet detects the cgroup driver from any container runtime that implements the
RuntimeConfigCRI RPC, yet the Container Runtimes page still makes the detection depend on theKubeletCgroupDriverFromCRIfeature gate. Its containerd and CRI-O sections still call it an alpha feature of v1.28.The gate is GA and locked on (kube_features.go, KEP-4033). The gate's entry on the Feature Gates page names containerd 2.0 and later and CRI-O 1.28 and later as the runtimes that support it. This PR removes the gate condition from the Container Runtimes page and replaces its two alpha sentences with these versions.
The gate's entry says the
cgroupDriverfallback ends in 1.36, but the v1.37 kubelet still uses it. This PR changes the date to 1.38, same as #55954 did on the Container Runtimes page. It also ends the entry's beta stage at 1.33 and marks its stable stage as locked, to matchkube_features.go.I used AI for research and drafting.
/sig node