Repository navigation
Conversation
github-actions
Bot
added
vouch:trusted
…second (pingdotgg#17029) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…pingdotgg#17028) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ngdotgg#17079) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
pingdotgg#15385) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…gdotgg#15397) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ingdotgg#15893) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…otgg#16296) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…dotgg#16330) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…id (pingdotgg#17211) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…rs (pingdotgg#17077) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>
…otgg#17214) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…otgg#14314) Co-authored-by: PR Batch Tester <agent@local.test> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…otgg#17271) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…17291) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…gg#11059) Co-authored-by: Claude Code <noreply@anthropic.com> Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
…dflared (pingdotgg#17275) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
juliusmarminge
force-pushed
the
muse/relay-client-download-timeout
branch
from
October 8, 2026 20:15
003d910 to
822e4f1
Compare
…pingdotgg#16998) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…0585) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
cloudflared's downloadAsset ran httpClient.execute and response.arrayBuffer
with no deadline. A wedged-but-alive endpoint (or a stalled drip) parked the
relay-client install forever - same unbounded-wait family as the codex/app-
server request timeouts and the OAuth/relay-unlink CLI timeouts.
Wrap both network hops in Effect.timeout(CLOUDFLARED_DOWNLOAD_TIMEOUT)
(10 minutes, generous for a ~40MB binary). Expiry flows through the
existing mapError into RelayClientInstallError{reason: download_failed},
so the install error contract is unchanged.
Authored with AI assistance (Muse, Meta's Muse Spark) under the
contributor's direction. The contributor reviewed the diff and ran the
focused tests before opening this PR.
juliusmarminge
force-pushed
the
muse/relay-client-download-timeout
branch
from
October 8, 2026 20:25
822e4f1 to
89f9bff
Compare
This was referenced Oct 16, 2026
Owner
Author
|
LANDED — closing this stale downstream mirror, not merging it. Canonical pingdotgg/t3code#14139 is merged (2026-10-08T20:31:54Z) as Original Kevin Rajan / kvnloo contribution implemented with Meta Muse Spark via Muse; juliusmarminge current-main rebase and test port. Original PR body, historical tests/reviews, commit ancestry and branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: cloudflared's
downloadAssetranhttpClient.executeandresponse.arrayBufferwith no deadline. A wedged-but-alive endpoint (or a stalled drip) parked the relay-client install forever — same unbounded-wait family as the previously fixed codex/app-server request timeouts and the OAuth/relay-unlink CLI timeouts.Fix: wrap both network hops in
Effect.timeout(CLOUDFLARED_DOWNLOAD_TIMEOUT)(10 minutes, generous for a ~40MB binary). Expiry flows through the existingmapErrorintoRelayClientInstallError{reason: "download_failed"}, so the install error contract is unchanged. 2 files, +59 lines.Validation:
fails a stalled download after the download timeout(TestClock + forkChild + never-responding HttpClient): FAILS on base (hangs to the 60s vitest timeout — the defect is literally a hang), passes with the fix.relayClient.test.ts: 6/6 green with fix.tsc --noEmitclean onpackages/shared.vp fmtclean.Authored with AI assistance (Muse, Meta's Muse Spark) under the contributor's direction. The contributor reviewed the diff and ran the focused tests before opening this PR.