Skip to content

[muse] fix(server): reject checkpoint revert while a turn is active - #6

Open
kvnloo wants to merge 1 commit into
mainfrom
muse/checkpoint-revert-active-turn-guard
Open

kvnloo wants to merge 1 commit into
mainfrom
muse/checkpoint-revert-active-turn-guard

Conversation

@kvnloo

@kvnloo kvnloo commented Sep 28, 2026

Copy link
Copy Markdown
Owner

What Changed

The decider now rejects thread.conversation.revert and thread.checkpoint.revert while the thread session is starting or running, mirroring the existing session-stop guard.

Why

Both commands rewrite the conversation and working tree underneath a live turn. The client blocks this, but a stale client or a direct command can still reach the server.

Validation

  • decider.revertGuard 4/4 green (red-on-base: 2 failed, 2 passed).

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • No UI changes

Authored with AI assistance (Muse, Meta's Muse Spark) under the contributor's direction.

thread.conversation.revert and thread.checkpoint.revert rewrite the
conversation and working tree underneath a live turn. The client blocks
this, but a stale client or a direct command can still reach the server.
The decider now rejects both commands while the thread session is
starting or running, mirroring the existing session-stop guard.

Tests: decider.revertGuard 4/4 green (red-on-base: 2 failed, 2 passed).

Authored with AI assistance (Muse, Meta's Muse Spark) under the
contributor's direction.
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S labels Sep 28, 2026
@kvnloo kvnloo added the keep pr-janitor: never auto-close label Oct 17, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

keep pr-janitor: never auto-close size:S vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant