Repository navigation
Conversation
Contributor
PR Analysis Report📚 Storybook PreviewGitHub Pages may take up to a minute to hydrate after the deploy. 🧩 Changed Components
2 changed component(s) with no story to open
26 other changed file(s) in
|
| File | Size | Gzip |
|---|---|---|
backend.ai-ui.js |
1414.3 kB | 360.3 kB |
dayjs.min-aRhWYanC.js |
95.1 kB | 27.7 kB |
th-C4jfBtNj.js |
49.3 kB | 10.3 kB |
el-CavMQDsC.js |
43.6 kB | 11.5 kB |
ru-H8nqgFFm.js |
40.7 kB | 10.8 kB |
mn-BxyZxuJ5.js |
40.2 kB | 10.6 kB |
ja-BtFsMuKd.js |
34.9 kB | 10.0 kB |
vi-Bcqy4LdF.js |
33.0 kB | 9.6 kB |
fr-CZ-eHNsp.js |
32.0 kB | 9.6 kB |
ko-Bb32H6Ak.js |
31.4 kB | 9.6 kB |
es-DdNV-h6x.js |
31.1 kB | 9.4 kB |
de-CbFEfA43.js |
31.1 kB | 9.6 kB |
it-DD4euzsb.js |
31.0 kB | 9.3 kB |
pt-BR-Cbf_3YVR.js |
30.7 kB | 9.3 kB |
pt-DW4E6r-c.js |
30.7 kB | 9.3 kB |
pl-CF0zuQ26.js |
30.5 kB | 9.7 kB |
tr-DL8H77n1.js |
30.1 kB | 9.4 kB |
fi-k38CvtC2.js |
29.9 kB | 9.4 kB |
ms-CQM72fiU.js |
29.2 kB | 9.0 kB |
id-D_84X5q5.js |
29.1 kB | 8.9 kB |
zh-TW-Cw50I2iv.js |
27.5 kB | 9.6 kB |
zh-CN-B4zoFQtW.js |
27.3 kB | 9.5 kB |
No base measurement — the merge-base build was skipped (dependency changes, or the base build failed).
Contributor
Contributor
Coverage Report for react-coverage (./react)
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
Author
|
Dev server on box |
agatha197
force-pushed
the
fix/gh-10493-disabled-option-reason
branch
from
October 23, 2026 01:11
8936c7c to
84c4471
Compare
Contributor
Author
|
📍 Walkthrough · 2 stops · 84c4471 — Open the walkthrough
|
A select option's `disabled` now takes `boolean | { reason: string }`
(`BAIOptionDisabled`), the shape BAINameActionCell row actions already
use. BAISelect and BAIComplexSelect draw a glyph at the end of a disabled
option whose tooltip carries the reason, so the row keeps its height when
many options share one reason, and the reason names the glyph for screen
readers. The glyph re-enables pointer events, which a disabled Astryx
Selector item turns off.
BAIScopedVFolderSelect takes `getFolderDisabled` returning the same union
instead of the boolean `isFolderDisabled`. The mount-folder input, project,
access key, model card, mount-permission, accelerator unit and runtime
preset value/UI type pickers pass a reason. ResourcePresetSelect and
ProjectSelect drop their own row tooltips and parallel `disabledReason`
field for the shared rendering.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…line The creator email now reads like the usage mode, host and date beside it: plain text between the existing separators. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
agatha197
force-pushed
the
fix/gh-10493-disabled-option-reason
branch
from
October 26, 2026 05:17
7d947cb to
0ffd311
Compare
Contributor
Author
Ready-gate agent review (Opus) - blocking issues only
Copilot: unavailable (insufficient remaining quota) - this review gated the PR alone. |
agatha197
marked this pull request as ready for review
October 26, 2026 05:38
…-option-reason Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> # Conflicts: # packages/backend.ai-ui/src/components/BAISelect.tsx # react/src/components/ResourcePresetSelect.tsx # react/src/components/VFolderNodeDescriptionV2.tsx
nowgnuesLee
requested changes
Oct 27, 2026
ui-common now takes `disabled: { reason }` on Selector / MultiSelector
options and `isDisabled: { reason }` on PagedSelector options, and draws the
row-end glyph itself (lablup/ui-common#107). BAISelect and BAIComplexSelect
pass the union through, the folder mount-permission picker and
ResourcePresetSelect set it on their options, and BUI's
BAIDisabledOptionReason is removed. Pinned to the ui-common#107 preview.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
agatha197
requested review from
nowgnuesLee
and
a balanced review from Copilot
October 27, 2026 09:25
agatha197
marked this pull request as ready for review
October 27, 2026 09:28
…i-common#107 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-option-reason # Conflicts: # react/src/components/ProjectSelect.tsx # react/src/generated/searchIndex.json # resources/i18n/de.json # resources/i18n/el.json # resources/i18n/en.json # resources/i18n/es.json # resources/i18n/fi.json # resources/i18n/fr.json # resources/i18n/id.json # resources/i18n/it.json # resources/i18n/ja.json # resources/i18n/ko.json # resources/i18n/mn.json # resources/i18n/ms.json # resources/i18n/pl.json # resources/i18n/pt-BR.json # resources/i18n/pt.json # resources/i18n/ru.json # resources/i18n/th.json # resources/i18n/tr.json # resources/i18n/vi.json # resources/i18n/zh-CN.json # resources/i18n/zh-TW.json
…-option-reason # Conflicts: # pnpm-lock.yaml
…rd to Board items The ui-common release carrying disabled option reasons also drops Board's renderItem; BAIBoard now hands each item's content to Board directly (same change as #10627). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-option-reason # Conflicts: # pnpm-lock.yaml # react/src/generated/searchIndex.json # resources/i18n/de.json # resources/i18n/el.json # resources/i18n/en.json # resources/i18n/es.json # resources/i18n/fi.json # resources/i18n/fr.json # resources/i18n/id.json # resources/i18n/it.json # resources/i18n/ja.json # resources/i18n/ko.json # resources/i18n/mn.json # resources/i18n/ms.json # resources/i18n/pl.json # resources/i18n/pt-BR.json # resources/i18n/pt.json # resources/i18n/ru.json # resources/i18n/th.json # resources/i18n/tr.json # resources/i18n/vi.json # resources/i18n/zh-CN.json # resources/i18n/zh-TW.json
…-option-reason # Conflicts: # react/src/components/VFolderNodeDescriptionV2.tsx
nowgnuesLee
requested changes
Oct 30, 2026
…needs ui-common's Board no longer takes renderItem, so BAIBoard passes each item's data.content as its description and strips it again in onItemsChange. The padding, header and doc rewrites copied from #10627 go back to main; the dashboard rework lands them on its own. Also regenerates searchIndex.json after the main merge dropped the folder detail mount permission selector. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
BAIScopedVFolderSelect takes disableUnmountable instead of a getFolderDisabled callback and supplies the no-mount-permission reason itself, so the key moves to its namespace. BAISelect / BAIComplexSelect option types point at the ui-common option types instead of restating the union. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The ui-common canary this PR pins also carries ui-common's Board API change, which the dashboard stack (#10619 and below) adopts in full. Keeping a second BAIBoard adaptation here would only conflict with it, so BAIBoard goes back to main's. Until the dashboard stack lands, tsc reports BAIBoard on this branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
agatha197
added a commit
that referenced
this pull request
Oct 30, 2026
Moves @lablup/ui-common and @lablup/ui-common-cli to 0.2.0-alpha.20.canary-20261029050354-1feb007cd, which carries lablup/ui-common#107 (needed by #10496). No codemods run between the two canaries; the AGENTS.md ui-common blocks are regenerated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #10493
Depends on lablup/ui-common#107 (merged) - pinned to the canary
0.2.0-alpha.20.canary-20261029050354-1feb007cdthat carries it.Summary
A select option that cannot be picked now says why. The option's disabled flag takes
boolean | { reason: string }, and the select draws a small glyph at the end of the disabled row whose tooltip carries the reason.disabled: truestill disables silently.The rendering lives in ui-common (lablup/ui-common#107):
Selector/MultiSelectoroptiondisabledandPagedSelectorOption.isDisabledtake the union. This PR only passes it through and sets reasons.Changes
BAISelectandBAIComplexSelectoptions acceptdisabled: boolean | { reason }and hand it to ui-common unchanged (BAIComplexSelectmaps it toisDisabled).BAIScopedVFolderSelect:isFolderDisabled→disableUnmountable; the select disables folders whose mount level is NONE and supplies the reason itself.ProjectSelect(locked project type),AccessKeySelect(inactive keypair),ModelCardSelect(no compatible preset), session launcher accelerator unit (not supported by the image), runtime variant preset value type / UI type.ResourcePresetSelectandProjectSelect(personal project) drop their own rowTooltip, thepointerEventsworkaround and the paralleldisabledReasonfield.#10279 is stacked on this PR
#10279 (preset list from
checkPresetAvailabilityV2, per-check preset reasons) sits on top and setsdisabled: { reason }on its preset options the same way.ui-common pin and
BAIBoardThe canary that carries lablup/ui-common#107 also carries ui-common's breaking
Boardchange (lablup/ui-common#68), which dropsrenderItem. This PR leavesBAIBoardto the dashboard stack (#10619 and the PRs below it), which adopts the newBoardin full, so the two do not both rewrite it. Until that stack lands,tscreportsBAIBoard.tsxon this branch; once it is on main, rebase this PR and the errors go.Out of scope
Disabled items in row-action and dropdown menus (
SessionNodes,AdminDeployment,DeploymentBasicInfoCard, …).Verification
VERIFY_TESTS=1 bash scripts/verify.sh: every lane passes except TypeScript, which reports onlyBAIBoard.tsxuntil the dashboard stack lands (above). Vitest:BAIComplexSelect,BAISelect*,ProjectSelect,SessionFormItemspass. The ui-common side has its own tests in lablup/ui-common#107.🤖 Generated with Claude Code
🔗 Dev server: https://gh-10493-pr10496-say-why-select.sujin.10-82-0-159.sslip.io