[agatha197]

Resolves #10583

Summary

Fourth layer of the role-aware dashboard stack (#10422). The admin dashboard gets real routes and one menu entry that resolves by role.

• Routes: AdminDashboardPage takes a page prop and is mounted at /admin/dashboard (admin, superadmin only) and /project/:projectName/admin/dashboard (projectAdmin). The project admin page reads its project from the URL only; the superadmin page passes no project and its page query counts the current domain (ADR 0012). Legacy /admin-dashboard redirects by role.
• One menu entry: admin-dashboard is the first admin sidebar item for superadmins and for the current project's project admin; domain admins keep today's behaviour (no dashboard entry). pathBuilder.ts gains a role-aware resolver (superadmin wins); getPathFromMenuKey takes the admin role; /project/:name/admin lands a project admin on the dashboard.
• Project-agnostic only on /admin: admin-dashboard is in PROJECT_AGNOSTIC_MENU_KEYS with canonical path /admin/dashboard, and useIsProjectAgnosticPage also checks the route scope, so the project admin page keeps the header project selector.
• Explicit project: DashboardPanelBoard takes a project prop; cards read it through useDashboardProject / useDashboardQueryScope. AdminDashboardPage.tsx and DashboardPanels/** join the ESLint ban on the ambient project.
• Catalog: agent stats and active agents only on the superadmin dashboard; the project-wide active sessions card only on the admin dashboards. The member dashboard query no longer asks for agent stats.
• ADR 0001 amended (the admin dashboard is no longer an exception; key list updated), ADR 0018 gains the project admin page rules; docs/ARCHITECTURE.md row updated.

Changes after the 2026-10-26 review

• Pinned boards are gone (Store dashboard boards in manager app config with role templates #10581), so the code that moved the URL to a pinned board's project is removed. The admin dashboards use the same refresh bar and per-card settings as the member dashboard: no project, resource group or range picker above the board. The superadmin resource group totals card has its own query and resource group setting.

Behaviour notes for review

• Domain admins can still open /project/:n/admin/dashboard by URL through the subtree's default access (a comment on the route says so); scoped reads authorize the data.
• The project admin dashboard shows only Active Sessions and custom panels until Project admin dashboard cards scoped to the managed projects #10585 adds its cards.
• webui.menu.AdminDashboard had no other users and is removed from all locales; the route label is webui.menu.Dashboard.
• Running prettier on ADR 0001 reformatted a few unrelated lines (required by the Format check).

Verification

VERIFY_BASE=feat/gh-10582-dashboard-filter-bar bash scripts/verify.sh
...
total: 19s
=== ALL PASS ===

• VERIFY_TESTS=1: react Vitest 76 files, 841 tests pass; new useWebUIMenuItems.test.tsx role matrix (superadmin, domain admin, project admin, user); updated path, header and project-agnostic tests.
• Browser check as a superadmin against a 26.10 manager: "Admin Settings" opens /admin/dashboard, whose first sidebar item is "Dashboard"; the page shows the board tab, the filter bar and the admin cards without a header project selector; /admin-dashboard redirects there; /project/default/admin/dashboard keeps the header selector; the member dashboard no longer shows agent cards.

Server load

• The page query includes the session count, recently created sessions, total resources and agent stats fragments only while a rendered card reads them, refreshes no faster than its fastest reader (never faster than the previous 15s / 30s page interval), and stops refreshing when no card reads it. The project admin page no longer fetches recently created sessions, up to 100 agents with their slots, or (for a superadmin) agent stats every 30s, none of which it can show; a card removed from a board stops being fetched.

🤖 Generated with Claude Code

Walkthrough

• Walkthrough

Not shown in the walkthrough:

• Domain admin view: no Dashboard item in the admin sidebar (this server signs in as a superadmin)
• Legacy /admin-dashboard redirecting by role
• Picking a pinned board on the project admin page moving the URL to its first pinned project
• ADR 0001 and ADR 0018 updates, ESLint ambient-project ban on the dashboard engine
• Menu role-matrix and path-resolution tests

Decisions (2026-10-29)

• The page query refreshes on every dashboard tick while a rendered card reads it; pageQueryRefresh (the fastest reader's minimum) is removed with the per-card minimums (ADR 0018).

Risk tier: High — docs/ARCHITECTURE.md, docs/adr/0001-explicit-project-prop-contract.md, docs/adr/0018-dashboard-filter-bar.md, react/eslint.config.js, react/src/hooks/useRouteScope.ts
Suggested human approvals: 2 (branch protection decides)
Reviewed by fw ready gate at afa5dda (round 1)

Ready gate (round 1)

• ec5b272: the superadmin page keeps its own domain-wide resource group; the session grid and the deployment/data presets read the page's scope (project or current domain); the eslint block repeats the useSetCurrentProject ban; stale JSDoc removed.

[agatha197]

Dev server on box sujin: stopped (was http://gh-10584-pr10596-rebuild-member-dashboard.sujin.10-82-0-159.sslip.io)

[agatha197]

📍 Walkthrough · 4 stops · 38dec72 — Open the walkthrough
Served by gh-10583-pr10595-add-admin-dashboards.

1. Dashboard › page-admin-dashboard › div "Skip to content Admin Settings Dashboard Operations Users Projec" — added menu
   The admin settings sidebar gained "Dashboard" as its first item. One entry serves both admin roles: a superadmin lands on /admin/dashboard, a project admin on /project//admin/dashboard. Before, the admin dashboard had no menu entry.
   check: Signed in as a superadmin, "Admin Settings" opens this page with "Dashboard" highlighted at the top of the sidebar; a domain admin sees no Dashboard item.
   code: react/src/hooks/useWebUIMenuItems.tsx:1, react/src/helper/pathBuilder.ts:1
2. Dashboard › page-admin-dashboard › button "New board" — added button
   The superadmin dashboard shows the board tabs from the storage layer: "Default" plus "New board", with edit and delete next to the active tab. They were unreachable before this route existed.
   check: "New board" adds a "Board 2" tab seeded from the default layout; deleting it asks for confirmation, and the last board cannot be deleted.
   code: react/src/components/DashboardPanels/DashboardBoardTabs.tsx:1
3. Dashboard › dashboard-filter-bar › div "ProjectsAll projectsNo resultsTotal 0 itemsResource groupsAll re" — added toolbar
   The superadmin dashboard has no header project selector; its filter bar picks projects of the current domain instead, and the cards read that domain (agent stats and active agents now appear only here).
   check: "All projects" lists this domain's projects; with none chosen, Active Sessions counts the whole current domain. The header shows no project selector on this page.
   code: react/src/pages/AdminDashboardPage.tsx:1, react/src/components/DashboardPanels/panelCatalog.tsx:300
4. Dashboard › dashboard-filter-bar › div "Projects default Resource groups All resource groups Time range " — added toolbar
   The project admin dashboard lives under the project admin pages and keeps the header project selector; its filter bar starts on the URL's project.
   check: The filter bar's project picker reads "default" (the project in the address); switching the header project moves the page to that project's dashboard.
   code: react/src/routes.tsx:1, react/src/hooks/useIsProjectAgnosticPage.ts:1

[github-actions]

Coverage Report for react-coverage (./react)

Status	Category	Percentage	Covered / Total
🔵	Lines	24.75%	10052 / 40611
🔵	Statements	22.08%	13309 / 60275
🔵	Functions	21.37%	1706 / 7981
🔵	Branches	17.62%	7601 / 43115

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
react/src/routes.tsx	19.32%	2.73%	0%	23.55%	55-56, 58-59, 61, 62, 65-66, 67, 69-70, 71, 72, 74-75, 77-78, 79, 81-82, 84-85, 87-88, 90-91, 94-95, 97-98, 100-101, 102, 104-105, 106, 108, 109, 110, 111, 113-114, 116-117, 118, 120, 122, 123, 125-126, 128, 129, 131-132, 133, 135-136, 138-139, 141-142, 144-145, 147-148, 150-151, 153-154, 156-157, 159-160, 162-163, 166-167, 172-176, 193-229, 238-242, 311-1407, 1447-1458, 1462-1464, 1481-1488, 1608-1667
react/src/components/SessionResourceGrid.tsx	3%	0%	0%	4.34%	112-116, 119, 126-129, 162-500
react/src/components/TotalResourceWithinResourceGroup.tsx	2.45%	0%	0%	3.96%	110-157, 177-182, 196-422
react/src/components/UserDropdownMenu.tsx	2.09%	0%	0%	3%	56, 59-60, 80-233
react/src/components/DashboardPanels/DashboardEditSider.tsx	0%	0%	0%	0%	52-277
react/src/components/DashboardPanels/DashboardPanelBoard.tsx	0%	0%	0%	0%	39-169
react/src/components/DashboardPanels/DeploymentNodesPanel.tsx	2.89%	0%	0%	4.25%	42-90
react/src/components/DashboardPanels/ResourceCountPanel.tsx	3.07%	0%	0%	6.06%	33-39, 60-85
react/src/components/DashboardPanels/ResourceTablePanel.tsx	3.09%	0%	0%	5.35%	50-68, 111-149
react/src/components/DashboardPanels/SessionNodesPanel.tsx	1.51%	0%	0%	2.22%	32-69
react/src/components/DashboardPanels/SessionResourceGridPanel.tsx	3.5%	0%	0%	6.45%	29-34, 61-67
react/src/components/DashboardPanels/boardModel.ts	96.26%	86.56%	92.45%	96.39%	79-81, 194-197, 386, 407-411
react/src/components/DashboardPanels/pageQuery.ts	100%	100%	100%	100%
react/src/components/DashboardPanels/panelCatalog.tsx	15.28%	12.35%	20%	23.95%	46-48, 52-54, 58-61, 76-78, 92-95, 114-117, 133-138, 155-159, 175-185, 215-216, 227-229, 238-240
react/src/components/DashboardPanels/resourceRegistry.tsx	26.08%	0%	4.54%	28.57%	58, 66-70, 76-87, 96-99, 111-117, 163-180, 223-259, 299-344, 361-365, 372-374
react/src/components/DashboardPanels/types.ts	100%	100%	100%	100%
react/src/components/DashboardPanels/useDashboardBoard.tsx	0%	0%	0%	0%	64-283
react/src/components/DashboardPanels/useDashboardFilters.tsx	12.72%	0%	0%	18.91%	38-43, 57-63, 90, 94, 98-103
react/src/components/MainLayout/WebUIHeaderProjectSelect.tsx	1.03%	0%	0%	1.38%	52-77
react/src/components/MainLayout/WebUISiderNavigation.tsx	1.78%	0%	0%	2.77%	35-119
react/src/helper/pathBuilder.ts	100%	100%	100%	100%
react/src/helper/projectAgnosticRoutes.ts	100%	75%	100%	100%
react/src/hooks/useIsProjectAgnosticPage.ts	100%	85.71%	100%	100%
react/src/hooks/useRouteScope.ts	53.19%	42.62%	58.33%	57.33%	194-210, 239-243, 275-282
react/src/hooks/useWebUIMenuItems.tsx	94.13%	66.1%	86.2%	92.51%	200, 401, 639-654, 672, 898-914, 907
react/src/pages/AdminDashboardPage.tsx	0%	0%	0%	0%	32-146
react/src/pages/DashboardPage.tsx	0%	0%	0%	0%	29-120

Generated in workflow #2734 for commit 9b15068 by the Vitest Coverage Report Action

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

[agatha197]

Ready-gate agent review (Opus) - blocking issues only

No blocking issues.

Copilot: unavailable (insufficient remaining quota) - this review gated the PR alone. The fixes above landed after the review and were not re-reviewed; verified by VERIFY_TESTS=1 scripts/verify.sh ALL PASS on the stack top 8a250e2ad2 and on the review server.

[agatha197]

Ready-gate agent review — 7 findings — 5 Important, 2 Nit, 0 Pre-existing. The summary comment on this PR lists every finding and its outcome.

[agatha197]

7 findings — 5 Important, 2 Nit, 0 Pre-existing

Round 1 — afa5dda

#	Tag	File:line	Finding	Outcome
1	Important	react/eslint.config.js:205	This per-file block redeclares no-restricted-imports, which replaces the global options, and its patterns omit the FR-3428 useSetCurrentProject ban; adding AdminDashboardPage.tsx and DashboardPanels/** here lifts that ban for those files, contrary to the block's own note that the global patterns are repeated.	fixed ec5b272
2	Important	react/src/components/DashboardPanels/SessionResourceGridPanel.tsx:77	On the superadmin page project is null, so the grid runs compute_session_list(group_id: null) with no domain_name and lists sessions from every domain, while the same panel in table view scopes to domain:<current>; ADR 0018 (amended in this PR) says a null project means the current domain.	fixed ec5b272
3	Nit	react/src/components/DashboardPanels/panelCatalog.tsx:52	Page-query cards render null while their fragment is excluded, and the fragment set is deferred, so a newly added My Sessions / Active Sessions card shows an empty body with no skeleton for the whole background round trip.	not-worth
4	Nit	react/src/components/DashboardPanels/types.ts:215	The old JSDoc ('Fragment keys of the page queries the built-in cards still read...') was left stacked above the new one on DashboardPageQueryRefs and describes the removed shape.	fixed ec5b272
5	Important	react/src/components/DashboardPanels/types.ts:283	The new domainName scope (null project = current domain) is ignored by the deployment and vfolder presets in resourceRegistry.tsx: deployment drops its project filter and queries myDeployments unfiltered on the superadmin page, and vfolder's makeOffsetVariables ignores both project and domain, so on the newly routed project admin page it lists every folder in the system.	fixed ec5b272
6	Important	react/src/helper/projectAgnosticRoutes.ts:47	Making /admin/dashboard project-agnostic unmounts the header project selector, but the superadmin page still takes its resource group from the now-hidden ambient project (useCurrentResourceGroupValue in AdminDashboardPage, useDashboardFilters, and the Total Resources card's SharedResourceGroupSelectForCurrentProject), so resource groups not bound to that project become unreachable.	fixed ec5b272
7	Important	react/src/pages/AdminDashboardPage.tsx:56	queryFetchKey switches on the non-deferred fragmentsKey while the variables use deferredFragmentsKey, so adding the first page-query card after a refresh tick gives the urgent render a new fetchKey with network-only and the query suspends into the route-level skeleton (the FR-3386 flash the deferral exists to prevent). The same block is in DashboardPage.tsx:47; basing queryFetchKey on deferredFragmentsKey avoids it.	intentional — superseded: the page query is removed in #10596

Security review: 0 findings

_{Posted inline: 7 · already inline from this round: 0 · table only (outside the diff): 0 · repeats of an earlier round dropped: 0 · Nits over the cap of 3 dropped: 0 · not posted (no file:line, or style-only): 0}