Repository navigation
Conversation
…r for a moment Cards whose settings include a resource group or a time range now show the value they read as a compact control in the card header. A pick there is kept in a jotai atom keyed by board and panel id, like the temporary table sort: auto refresh keeps it, leaving or reloading the page drops it, and saving the card settings in edit mode clears it. The board hands every card its effective settings (header pick, else saved, else default), so the cards' data, vars and detail links follow the pick without changes. A changed control turns to the secondary variant and a reset button returns to the saved setting. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
That card draws its own per-group header, so the first group's header carries the card's controls. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d-header-overrides
…d-header-overrides
The controls sat at the end of the header row, apart from what they change. They now follow the title and its help glyph, and the total resources card draws its resource group picker where the group name was, as the old dashboard did. The row's end keeps the card's own actions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With the header able to change a value for a moment, the edit-mode settings are the default the board opens with. The modal title, field labels and settings button now say so, and a line under the title says the header can change it for a moment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
…d-header-overrides
…d-header-overrides
…d-header-overrides # Conflicts: # react/src/components/DashboardPanels/DashboardPanelBoard.tsx # react/src/components/DashboardPanels/PanelFrame.tsx
…d-header-overrides
…d-header-overrides
…d-header-overrides
…d-header-overrides # Conflicts: # react/src/components/DashboardPanels/PanelFrame.tsx # react/src/components/DashboardPanels/PanelSettingsModal.tsx
…d plainly and label every group With several saved default groups the header picker stood in for the first group's name, so it read 'a, b' over group a's numbers. The card now has one header (the plain title, its help, the picker beside it and one Used/Free switch) and each resource group section carries its own name, the first included. The Korean title reads '자원 그룹별 총자원'. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
Ready-gate agent review (Opus) - blocking issues only
Copilot: unavailable (insufficient remaining quota) - this review gated the PR alone. The fixes above landed after the review and were not re-reviewed; verified by |
agatha197
marked this pull request as ready for review
October 27, 2026 13:41
This was referenced Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #10638
Summary
A card whose settings include a resource group or a time range now shows that value as a compact control by its title, like the old dashboard's "My resources in " select. A value picked there is a temporary view; the edit-mode card settings stay the saved default, and the settings modal now says so.
panelSettingOverrides.ts: a jotai atom of header picks keyed by board id and panel id (card ids repeat across boards), plus the pure resolution: effective = header pick ?? saved setting ?? card default.useDashboardBoard: every card gets its effective settings through the samepanel/vars/ detail-link inputs it already reads, so no card component changed how it reads them. Edit and save paths keep using the saved panel.PanelSettingsHeaderControls+PanelHeaderSettingsContext: the resource group select (BAIScopedResourceGroupSelect, sameresourceGroupScopeOfas the settings modal, moved todashboardScope.ts) and the range select (RANGE_PRESETS),size="sm".PanelFramerenders them right after the title and its help glyph; the row's end keeps the card's own actions and the detail link. The total-resources card draws the select where its resource group name was.useResetOnLeavingPath: the "reset when the path changes, not on a same-path remount" rule the board already used for edit mode and the temporary table sort, now a hook that also clears the header picks.Behaviour
Resource groups: the header picks one group, or clears to the card default (the current resource group, or all groups on a custom panel), the same
resourceGroupsshape the settings use. A saved choice of several groups is shown as the joined names until a single group is picked.Cards that got a control: My Total Resource Usage, Resource Presets, Total Resources in Resource Group, Pending Sessions and Reasons, Resource Groups and Capacity, Top Projects by Usage, Fair Share and custom table panels whose source supports a resource group (resource group); My Activity, Audit Log, Long-running Sessions, Scheduling Failures, Failures by Entity Type, Keypairs and Logins (range).
New i18n keys in all 21 locales:
dashboard.settings.BackToSavedSetting,DefaultSettingsOf,DefaultCardSettings,DefaultResourceGroups,DefaultTimeRange,DefaultSettingsHelp;CardSettings,CardSettingsOfandResourceGroupsare replaced and removed.Verification
VERIFY_BASE=origin/main VERIFY_TESTS=1 bash scripts/verify.sh:=== ALL PASS ===.panelSettingOverrides.test.ts(effective-value resolution, modified flags, override merge, board keying) anduseResetOnLeavingPath.test.ts(resets on a path change, not on a same-path remount)./admin/dashboard: Total Resources pickedsftp(CPU 11 → 15 Core); kept after the refresh button and after a 30 s auto refresh; back todefaultafter reload. Scheduling Failures picked "Last 7 days" (failures 666/669 → 7,270/7,281); back to "Last 24 hours" after reload./project/default/admin/dashboard: Long-running Sessions "Last 1 hour", Pending Sessionssftp; both back to the default after leaving and returning./project/default/dashboardas a plain user: My Total Resource Usage pickedsftp(13 → 17 Core); kept after refresh; back todefaultafter reload. The select lists the project's resource groups fromscopedResourceGroups.Where to look: any card with a resource group or time range on the three dashboard pages; the select sits right after the card title.
Changes after the ready-gate review
TotalResourcesInResourceGroupkey now reads), with the header picker and one Used/Free switch beside it like on other cards. Every resource group section, the first included, is labelled with its own group name, so two saved default groups no longer show "a, b" over group a's numbers.🤖 Generated with Claude Code