Repository navigation
Conversation
safetensors 0.8 returns `&str` from `SafeTensors::names()`, so the `name.as_str()` left in the Youtu-VL runtime hit the unstable `str_as_str` library feature and broke `cargo check --features cuda,xla-iree`, the OpenXLA feature compile job on #2819. That code needs `IREE_DIST` and could not compile locally, so this fix relies on the CI job. The XLA features are not part of the v0.8.0 release builds, which use `--features cuda` and the macOS defaults. Refs #2819
5 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
safetensors 0.8 returns
&strfromSafeTensors::names(), so thename.as_str()left in the Youtu-VL runtime hit the unstablestr_as_strlibrary feature and brokecargo check --features cuda,xla-iree, the OpenXLA feature compile job on #2819. That code needsIREE_DISTand could not compile locally, so this fix relies on the CI job.The XLA features are not part of the v0.8.0 release builds, which use
--features cudaand the macOS defaults.Refs #2819