fix(mem-wal): install conflicts with concurrent schema-changing merge - #8539
Merged
wkalt merged 2 commits intoAug 14, 2026
Merged
Conversation
initialize_mem_wal validates schema-dependent state -- sharding fields and maintained indexes -- so a Merge that commits concurrently invalidates what the install validated, yet both interleavings committed: check_create_index_txn accepted any Merge and check_merge_txn accepted any CreateIndex. Both arms now conflict when the CreateIndex carries the MemWAL index; ordinary column-index builds stay compatible with Merge.
Contributor
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
wkalt
changed the title
![lance-gatekeeper[bot]](https://avatars.githubusercontent.com/in/4433141?s=60&v=4){kind=small}
lance-gatekeeper
Bot
added
the
K-approved
Xuanwo
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
initialize_mem_wal validates schema-dependent state -- sharding fields and
maintained indexes -- so a Merge that commits concurrently invalidates what
the install validated, yet both interleavings committed: check_create_index_txn
accepted any Merge and check_merge_txn accepted any CreateIndex. Both arms now
conflict when the CreateIndex carries the MemWAL index; ordinary column-index
builds stay compatible with Merge.