docs: classify the fragment's non-Lance referenced files by format - #8562
Merged
Xuanwo merged 6 commits intoAug 31, 2026
Merged
Conversation
The list named two of the four kinds. A fragment can also reference external row-version metadata through created_at_version_meta and last_updated_at_version_meta, both raw byte ranges like the external row-id file. Classifying by format instead of enumerating keeps the boundary correct as kinds are added.
Contributor
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The latest merge from main leaves the documentation patch unchanged. The storage-based classification still matches the current deletion-file suffixes and external row-id and row-version byte-range representations without changing behavior.
Contributor
Author
|
Thank you @Xuanwo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fragment::referenced_lance_filesdocuments which of a fragment's referenced files it does not yield, and the list named two of the four kinds. A fragment can also reference external row-version metadata throughcreated_at_version_metaandlast_updated_at_version_meta, bothRowDatasetVersionMeta::External(ExternalFile)just like the external row-id file.Classify by format instead of enumerating, so the boundary stays correct as kinds are added: a deletion file is
.arrowor.binperDeletionFileType::suffix, and external row-id or row-version metadata is anExternalFile, a(path, offset, size)byte range rather than a Lance file.This matters because the omission reads as a statement about what is referenced at all.
Dataset::referenced_filesin #8097 refuses outright on each of those three external kinds, precisely because they are referenced but not enumerated by any per-file walk; a reader of this doc could reasonably conclude row-version metadata is not a referenced file.Docs only, no code change.
cargo fmt --all --check,cargo clippy -p lance-table --all-targets -- -D warnings, andRUSTDOCFLAGS="-D warnings" cargo doc -p lance-table --no-depsare clean;lance-tableformattests pass (32).