docs: correct stable row ID migration and storage - #8852
docs: correct stable row ID migration and storage#8852lance-gatefixer[bot] wants to merge 127 commits into
Conversation
|
Important Format specification voteThis PR modifies the Lance format specification, so it requires 3 binding +1 votes from PMC members (excluding the proposer) and a minimum 72-hour voting period, weekends excluded, before it can merge. Vote by approving this PR (+1) or requesting changes (−1, a veto). See the voting process. Status: ❌ Blocked — 0 of 3 required approvals
Updated automatically by the format-spec vote gate, which re-checks every 15 minutes — just voted? Re-check now (press Run workflow; leave the input blank to re-check every open format PR). A PMC member may apply the |
|
Blocked: the current head cannot pass Remote head |
|
Blocked: the current head cannot pass Remote head |
|
Blocked: the current head is held by an unrelated Windows runner failure and the required format-spec approval gate. Remote head |
|
Blocked: the current head remains held by an unrelated Windows hosted-runner failure and the required format-spec approval gate. Remote head |
|
Blocked: the current head cannot satisfy Remote head |
|
Blocked: the current head cannot satisfy format-spec-vote until the required PMC approval process completes. Remote head 01197a5 contains the current main tip 085354e. The live format-spec-vote status targets Actions run 33217104161 and reports 0/3 PMC approvals on this commit; its evaluator job 99003082863 completed successfully, and all 32 current-head CheckRuns pass. I fetched both branches, verified ancestry and remote identity, inspected the current status and evaluator logs, and ran git diff --check; no attributable code defect remains to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals after the required voting period; alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial. |
|
Blocked: the current head cannot satisfy format-spec-vote until the required PMC approval process completes. Remote head 01197a5 contains the current main tip 085354e. The live format-spec-vote status targets Actions run 33218990261 and reports 0/3 PMC approvals on this commit; its evaluator job 99008845859 completed successfully, and all 32 current-head CheckRuns pass. I fetched both branches, verified ancestry and remote identity, inspected the current status and evaluator logs, and ran git diff --check; no attributable code defect remains to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals after the required voting period; alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial. |
|
Blocked: the current head cannot satisfy format-spec-vote until the required PMC approval process completes. Remote head 01197a5 contains the current main tip 085354e. The live format-spec-vote status targets Actions run 33219934264 and reports 0/3 PMC approvals on this commit; its evaluator job 99011652281 completed successfully, and all 32 current-head CheckRuns pass. I fetched both branches, verified ancestry and remote identity, inspected the current status and evaluator logs, and ran git diff --check; no attributable code defect remains to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals after the required voting period; alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial. |
|
Blocked: the current head cannot satisfy format-spec-vote until the required PMC approval process completes. Remote head 01197a5 contains the current main tip 085354e. The live format-spec-vote status targets Actions run 33220685156 and reports 0/3 PMC approvals on this commit; its evaluator job 99013887195 completed successfully, and all 32 current-head CheckRuns pass. I fetched both branches, verified ancestry and remote identity, inspected the current status and evaluator logs, and ran git diff --check; no attributable code defect remains to repair. The smallest next action is for three eligible PMC members to provide binding +1 approvals after the required voting period; alternatively, a PMC member may apply format-waived if this documentation correction qualifies as trivial. |
|
Blocked: the current head cannot satisfy Remote head |
|
Blocked: the current head cannot satisfy Remote head |
|
Blocked: remote head The verified remote head contains current |
|
Blocked: remote head The verified remote head contains current |
|
Blocked: remote head The verified remote head contains current |
|
Blocked: remote head The verified remote head contains current The smallest next action is for three eligible PMC members to provide binding +1 approvals. Alternatively, a PMC member may apply |
|
Blocked: remote head The verified remote head contains current The smallest next action is for three eligible PMC members to provide binding +1 approvals. Alternatively, a PMC member may apply |
|
Blocked: remote head The verified remote head contains current The smallest next action is for three eligible PMC members to provide binding +1 approvals. Alternatively, a PMC member may apply |
|
Blocked: remote head The verified remote head contains current The smallest next action is for three eligible PMC members to provide binding +1 approvals. Alternatively, a PMC member may apply |
|
Blocked: remote head The verified remote head contains current The smallest next action is for three eligible PMC members to provide binding +1 approvals. Alternatively, a PMC member may apply |
|
Blocked: remote head The verified remote head contains current The smallest next action is for three eligible PMC members to provide binding +1 approvals. Alternatively, a PMC member may apply |
|
Blocked: remote head The verified remote head contains current The smallest next action is for three eligible PMC members to provide binding +1 approvals. Alternatively, a PMC member may apply |
|
Blocked: remote head The verified remote head contains current The smallest next action is for three eligible PMC members to provide binding +1 approvals. Alternatively, a PMC member may apply |
|
Blocked: remote head The verified remote head contains current The smallest next action is for three eligible PMC members to provide binding +1 approvals. Alternatively, a PMC member may apply |
|
Blocked: remote head The verified remote head contains current The smallest next action is for three eligible PMC members to provide binding +1 approvals. Alternatively, a PMC member may apply |
|
Blocked: remote head The verified remote head contains current The smallest next action is for three eligible PMC members to provide binding +1 approvals. Alternatively, a PMC member may apply |
|
Blocked: remote head The verified remote head contains current The smallest next action is for three eligible PMC members to provide binding +1 approvals. Alternatively, a PMC member may apply |
|
Blocked: remote head The verified remote head contains current The smallest next action is for three eligible PMC members to provide binding +1 approvals. Alternatively, a PMC member may apply |
|
Blocked: The current-head format-spec-vote check cannot pass because commit 57690d8 has 0 of the required 3 PMC approvals. Evidence: the remote repair head contains the current main tip 8a145b3; Actions run 34496362200, evaluator job 102935719123, completed successfully and reported 0/3 PMC approvals on this commit. Attempted: regenerated the protobuf descriptors, ran git diff --check, and built the documentation with uv run mkdocs build; validation passed (with existing documentation warnings), and a normal push confirmed the remote branch is up to date. Smallest action: obtain three PMC approvals on this commit. As a practical alternative, a maintainer can apply format-waived. |
|
Blocked: Remote head 57690d8 cannot satisfy format-spec-vote because current run 34499517372 reports 0/3 required PMC approvals. The remote repair head contains current main tip 8a145b3. Evaluator job 102946456240 and every step completed successfully, confirming this is the approval gate rather than an attributable code failure. Attempted: fetched and verified both refs and the exact Ready PR identity, inspected the current status and evaluator log, compiled protos/table.proto, ran git diff --check, built the documentation successfully with existing warnings, and confirmed a normal same-branch push was already up to date. The smallest next action is for three eligible PMC members to provide binding approvals on this commit. Alternatively, a PMC member may apply format-waived if the correction qualifies as trivial. |
|
Blocked: Remote head 279cc4e cannot satisfy format-spec-vote because current run 34502724332 reports 0/3 required PMC approvals. The remote repair head contains current main tip d7b031f. Evaluator job 102957202085 and every step completed successfully, confirming this is the approval gate rather than an attributable code failure. Attempted: fetched and verified both refs and the exact Ready PR identity, inspected the current status and evaluator log, compiled protos/table.proto, ran git diff --check, built the documentation successfully with existing warnings, and confirmed a normal same-branch push was already up to date. The smallest next action is for three eligible PMC members to provide binding approvals on this commit. Alternatively, a PMC member may apply format-waived if the correction qualifies as trivial. |
|
Blocked: Remote head 279cc4e cannot satisfy format-spec-vote because current run 34505723070 reports 0/3 required PMC approvals. The remote repair head contains current main tip d7b031f. Evaluator job 102967307902 and every step completed successfully, confirming this is the approval gate rather than an attributable code failure. Attempted: fetched and verified both refs and the exact Ready PR identity, inspected the current status and evaluator log, compiled protos/table.proto, ran git diff --check, built the documentation successfully with existing warnings, and confirmed a normal same-branch push was already up to date. The smallest next action is for three eligible PMC members to provide binding approvals on this commit. Alternatively, a PMC member may apply format-waived if the correction qualifies as trivial. |
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The pull-request patch remains unchanged. The new base commit only updates Torch and related dependency entries in python/uv.lock; it does not alter stable-row-ID migration, index coordination, physical-row accounting, or row/version-sequence storage. The corrected migration and storage guidance remains accurate.
|
Blocked: Remote head The remote repair head contains current Attempted: fetched and verified both refs and the exact Ready PR identity, inspected the current status and evaluator log, compiled The smallest next action is for three eligible PMC members to provide binding approvals on this commit. Alternatively, a PMC member may apply |
|
Blocked: Remote head The remote repair head contains current Attempted: fetched and verified both refs and the exact Ready PR identity, inspected the current status and evaluator log, compiled The smallest next action is for three eligible PMC members to provide binding approvals on this commit. Alternatively, a PMC member may apply |
|
Blocked: Remote head The remote repair head contains current Attempted: fetched and verified both refs and the exact Ready PR identity, inspected the current status and evaluator log, compiled The smallest next action is for three eligible PMC members to provide binding approvals on this commit. Alternatively, a PMC member may apply |
|
Blocked: Remote head The remote repair head contains current Attempted: fetched and verified both refs and the exact Ready PR identity, inspected the current status and evaluator log, compiled The smallest next action is for three eligible PMC members to provide binding approvals on this commit. Alternatively, a PMC member may apply |
|
Blocked: Remote head The remote repair head contains current Attempted: fetched and verified both refs and the exact Ready PR identity, inspected the current status and evaluator log, compiled The smallest next action is for three eligible PMC members to provide binding approvals on this commit. Alternatively, a PMC member may apply |
|
Blocked: Remote head The remote repair head contains current Attempted: fetched and verified both refs and the exact Ready PR identity, inspected the current status and evaluator log, compiled The smallest next action is for three eligible PMC members to provide binding approvals on this commit. Alternatively, a PMC member may apply |
Summary
Root cause
The format documentation and protobuf comments still described pre-implementation plans: they said existing datasets could not migrate and presented a 200 KB inline/external threshold as active writer behavior. Migration has since shipped, but writers still emit every sequence inline and readers cannot load external version sequences.
Validation
protoc --proto_path=../protos --descriptor_set_out=/dev/null ../protos/table.protouv run mkdocs build(completed with pre-existing missing-link warnings outside this change)git diff --checkFixes #8851