Repository navigation
chore: update vinext, add workaround - #32878
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on updating a key dependency and refining a development tool integration. The Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the vinext dependency and introduces a couple of workarounds. The react-scan developer tool is now loaded from a CDN via next/script instead of being bundled locally. Additionally, a defensive check has been added to HydrateQueryClient to handle cases where there's no dehydrated state, which improves robustness. My feedback includes a minor suggestion to improve the security and reliability of the CDN link for react-scan.
Note: Security Review did not run due to the size of the PR.
There was a problem hiding this comment.
Pull request overview
Updates the web build/dev tooling around Vinext and introduces small workarounds to keep the app functioning under the updated Vinext behavior.
Changes:
- Bump
vinextto a newer commit inweb/package.jsonandweb/pnpm-lock.yaml(new transitive deps added). - Add a guard to skip
HydrationBoundarywhen there’s no dehydrated state (Vinext workaround). - Replace the dev-only
react-scanlazy-loaded component with anext/scriptloader that pullsreact-scanfrom a CDN.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| web/pnpm-lock.yaml | Updates lockfile for the new Vinext commit and adds new transitive dependencies. |
| web/package.json | Bumps the Vinext dependency URL to the new commit. |
| web/app/components/plugins/marketplace/hydration-server.tsx | Skips HydrationBoundary when no dehydrated state is produced (workaround). |
| web/app/components/devtools/react-scan/scan.tsx | Removes the local React component integration for react-scan. |
| web/app/components/devtools/react-scan/loader.tsx | Switches to loading react-scan via next/script in dev mode. |
Files not reviewed (1)
- web/pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
web/app/components/plugins/marketplace/hydration-server.tsx:41
- Grammar nit in the TODO: "vinext do not handle hydration boundary well" should be "vinext does not handle … well" (and consider capitalizing
HydrationBoundarysince it’s a component).
// TODO: vinext do not handle hydration boundary well for now.
if (!dehydratedState) {
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- web/pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
web/app/components/plugins/marketplace/hydration-server.tsx:42
- The TODO comment has a grammar issue and no tracking reference. Consider changing it to “vinext does not handle HydrationBoundary well …” and include a link to the relevant vinext issue/PR so it’s clear when this guard can be removed.
// TODO: vinext do not handle hydration boundary well for now.
if (!dehydratedState) {
return <>{children}</>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Important
Fixes #<issue number>.Summary
Follow #32559
HydrationBoundaryScreenshots
Checklist
make lintandmake type-check(backend) andcd web && npx lint-staged(frontend) to appease the lint gods