vae.hpp: Replace free_compute_buffer with runner_done to fix memory not released - #1872
Merged
Conversation
free_compute_buffer does not seem to release all resources after the gen. Replaced free_compute_buffer() calls with runner_done() to fix subsequent generations failing due to insufficient memory that was not freed.
LostRuins
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In vae.hpp, free_compute_buffer() does not seem to release all resources after the gen. On some tight setups, this causes subsequent generations to fail due to insufficient memory that was not freed.
Replaced free_compute_buffer() calls with runner_done() to ensure all resources freed after a generation is done.
Additional Information
@wbruna recommended I PR this
Checklist