This repository was archived by the owner on May 4, 2023. It is now read-only.
Repository navigation
Conversation
dynox
reviewed
Jan 9, 2023
dynox
left a comment
dynox
left a comment
Contributor
There was a problem hiding this comment.
Hi @maxKusch.
Thanks for the suggestion to extend the functionality of the SDK. I think the path you outlined is correct except that to be consistent across the API - we would have to do the same for every response returned from the server.
Would you like to extend this functionality within this PR and add proper tests?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick solution to access rate limit information i order to prevent my software from spamming the lemon markets server with requests after the rate limit is exhausted.