Repository navigation
fix(window): honor final duplicate feature values - #2436
Merged
Merged
Conversation
ldm0
self-requested a review
November 6, 2026 02:49
Member
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WindowOpenFeatures::parsereplayed every raw occurrence of a feature after tokenizing, so an earlierlocation=yesortoolbar=yessurvived a later=noduplicate. The HTML tokenizer keeps only the last value for each name (tokenize the features argument), and popup classification reads from that map. Solocation=yes,location=no,menubar=yes,scrollbars=yes,status=yes,resizable=yesshould open a popup, and Moli opened a normal window.I dropped the private raw-entry list and parse the existing ordered map, so the last value wins for every feature. The public API doesn't change. The tests cover both duplicate orders for every popup input, plus the sequence above.
Tested:
cargo fmt --all --checkcargo clippy --workspace --all-targets --all-features -- -D warningscargo test -p moli-window-featurescargo test -p moli-renderer-v8 script_vm::tests::browser_api::bar_prop::bar_props_follow_popup_features_and_close -- --exactThe full
cargo nextest rundidn't fit in the disk space I had, so that one is left to CI.