hid_error implementation for libusb#708
Merged
Merged
Conversation
- hid_error is set correctly for most of the API functions (except hid_enumerate/hid_open/etc.); - refactored iconv routines - common code for utf16 and utf8 to wchar_t implementation; - `hid_libusb_error` to have libusb error code when possible; Closes: #690 Fixes: #684 Co-authored-by: Matheus Afonso Martins Moreira <matheus@matheusmoreira.com>
Member
Author
|
Still need to implement global error. |
Member
Author
|
This is ready now |
mcuee
approved these changes
Apr 26, 2026
Member
|
Looks good to me. |
Youw
added a commit
that referenced
this pull request
Jul 13, 2026
Brings in #813 (IWYU + leak guards), #815 (virtual-device test harness), #817 (CI vcvars fix, already cherry-picked) and #708 (libusb hid_error). Conflicts in libusb/hid.c (hotplug context vs last_global_error, refactored hid_enumerate vs its error reporting) and linux/hid.c (includes) resolved by keeping both sides' functionality. Assisted-by: claude-code:claude-fable-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hid_libusb_errorto have libusb error code when possible;Closes: #690
Fixes: #684
Co-authored-by: Matheus Afonso Martins Moreira matheus@matheusmoreira.com