Repository navigation
Conversation
… caching Agent-Generated-By: Codex
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Review readiness checklist
0/4 boxes ticked. Its title has been prefixed with |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughZCode exports now use the ChangesZCode provider configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: 🟡 Moderate · up to The code change is localized, but the PR is not merge-ready because its readiness checklist remains fully unchecked, including confirmation of tests, branch freshness, finding resolution, and review readiness. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
리뷰 · 우선순위 60 / 80제목 지금 캐시 이야기는 설득력 있음. Anthropic 메시지로 프롬프트 인라인/툴 결과가 매번 앞에 붙으면 DeepSeek KV prefix가 깨짐. 수동으로 Chat Completions 바꾸면 fingerprint 전 모델 kind를 한 번에 바꾸는 거라 Claude-on-ZCode가 Messages에 의존하면 깨질 수 있음. 프록시는 두 프로토콜 다 받으니 대체로 괜찮음. 그래도 ZCode 3.7.7에서 anthropic으로 검증해 둔 주석( types.ts/config.ts 스플릿이랑 상관 없음. 5줄짜리라 스플릿에 안 씹힘. 해결방안: base를 이 댓글은 grok-bot이 작성했습니다 |
|
Closing per the [WRONG BRANCH] marker: this targets main, and feature/fix PRs integrate through dev only (AGENTS.md branch policy; enforce-target also rejects main-tip ancestry). The zcode openai-compatible direction itself is welcome — please re-file the same diff against dev and it will ride the normal triage train. |
Summary
In current OpenCodex versions, ZCode client integration (
src/clients/config-export.ts) generates the provider configuration with:{ "kind": "anthropic", "options": { "baseURL": "http://127.0.0.1:10100" } }This causes two major issues:
When using Anthropic Messages protocol, prompt inlining and dynamic tool results break KV cache prefix alignment. In practice, DeepSeek's KV cache hit rate drops from 99% to ~80% (or lower).
When users manually switch the protocol to
Chat Completionsinside ZCode's UI, OpenCodex's fingerprint guard detects an unowned foreign edit (conflict: foreign-edit) and stops managing the client.Changes
ZcodeProviderBlock.kindandbuildZcodeClientConfiginsrc/clients/config-export.tsto useopenai-compatible.baseURLis exported with the/v1suffix (i.e.http://127.0.0.1:10100/v1), which matches ZCode's/chat/completionsURL concatenation.tests/zcode-client.test.tsunit tests to assert the new provider kind and baseURL.Verification
bun test tests/zcode-client.test.ts: 10 pass, 0 fail.Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
All CI tests are green on my local testing.
I pushed my PR to the latest dev commit.
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.
Summary by CodeRabbit
/v1path in exported base URLs for improved compatibility.