Skip to content

test(server): give the Daybreak compact case the server budget - #2635

Merged
lidge-jun merged 1 commit into
devfrom
codex/server-auth-daybreak-budget
Aug 25, 2026
Merged

lidge-jun merged 1 commit into
devfrom
codex/server-auth-daybreak-budget

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Aug 25, 2026 •

Copy link
Copy Markdown
Owner

Summary

A full-suite parallel run on the Linux test host reported one failure:

(fail) server local API auth > #2097: Daybreak compact uses the stable wire model without retention [5003.01ms]

5003ms is Bun's default 5s test timeout, not an assertion failure. The case passes 3/3 in isolation on both macOS and the Linux host.

It starts a real server through startPoolRetryHarness, and its neighbours in this file already declare SERVER_BUDGET_MS for that reason — this one was left on the default intended for pure unit tests. Under full-suite parallel load, server startup plus the request exceeded 5s.

Verification

bun test ./tests/server-auth.test.ts    86 pass / 0 fail

Isolation runs before the change: 3/3 pass on macOS (2.78s, 504ms, 737ms) and 3/3 on Linux (301ms, 325ms, 315ms) — which is what identifies this as load-dependent rather than a real defect.

Checklist

  • Targets dev
  • Test-only; no production behavior changed
  • Budget matches the existing convention in the same file

Summary by CodeRabbit

  • Tests
    • Updated the pool retry test to use the server time budget for more reliable timeout handling.

It timed out at 5003ms in a full-suite parallel run on the Linux box while
passing 3/3 in isolation on both macOS and Linux. 5003ms is Bun's default 5s
test timeout, not an assertion failure.

The case starts a real server through startPoolRetryHarness, and its neighbours
in this file already declare SERVER_BUDGET_MS for exactly that reason; this one
was left on the default meant for pure unit tests. Measuring a server-backed
case against that default under parallel load produces a flake, not a signal.
@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner August 25, 2026 22:00
@lidge-jun
lidge-jun merged commit 87179e8 into dev Aug 25, 2026
6 checks passed
@lidge-jun
lidge-jun deleted the codex/server-auth-daybreak-budget branch August 25, 2026 22:01
@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature). label Aug 25, 2026
@coderabbitai

coderabbitai Bot commented Aug 25, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 68a27bc7-aa29-42d3-9d1a-8c44891d7824

📥 Commits

Reviewing files that changed from the base of the PR and between 6ccb13c and 1dadec5.

📒 Files selected for processing (1)
  • tests/server-auth.test.ts

📝 Walkthrough

Walkthrough

The pool retry test in tests/server-auth.test.ts now uses SERVER_BUDGET_MS for its timeout instead of Bun’s default test timeout.

Changes

Server authentication test timeout

Layer / File(s) Summary
Pool retry timeout update
tests/server-auth.test.ts
The pool retry test now uses SERVER_BUDGET_MS as its timeout at lines 2246–2250.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: ingwannu, wibias, luvs01

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/server-auth-daybreak-budget

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

tarunravi pushed a commit to tarunravi/opencodex that referenced this pull request Sep 14, 2026
…-jun#2635)

It timed out at 5003ms in a full-suite parallel run on the Linux box while
passing 3/3 in isolation on both macOS and Linux. 5003ms is Bun's default 5s
test timeout, not an assertion failure.

The case starts a real server through startPoolRetryHarness, and its neighbours
in this file already declare SERVER_BUDGET_MS for exactly that reason; this one
was left on the default meant for pure unit tests. Measuring a server-backed
case against that default under parallel load produces a flake, not a signal.
agentHits pushed a commit to agentHits/opencodex that referenced this pull request Sep 17, 2026
…-jun#2635)

It timed out at 5003ms in a full-suite parallel run on the Linux box while
passing 3/3 in isolation on both macOS and Linux. 5003ms is Bun's default 5s
test timeout, not an assertion failure.

The case starts a real server through startPoolRetryHarness, and its neighbours
in this file already declare SERVER_BUDGET_MS for exactly that reason; this one
was left on the default meant for pure unit tests. Measuring a server-backed
case against that default under parallel load produces a flake, not a signal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant