Repository navigation
docs(config): separate data-plane API keys from management credentials - #5134
Conversation
The server-configuration table in English and all seven locale copies claimed generated apiKeys are accepted by management and data-plane auth. Runtime rejects data-plane credentials as management tokens (src/server/management-auth.ts). Correct each row to describe data-plane admission only, link the locale management reference, and record the row contract in the docs structure owner. Closes #5120
|
Warning Review limit reachedNext included review available in 5 seconds. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: lidge-jun/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (9)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
리뷰 · 우선순위 72 / 80이 PR은 서버 설정 표의 고친 뜻은 어디서나 같습니다. 생성된 키는 루프백이 아닌 바인드에서 데이터 플레인 입장용입니다. 관리 API는 허가하지 않고, 관리 자격 증명은 각 로케일의 관리 API 레퍼런스로 보냅니다. 링크 여덟 개가 전부 실제 라인 docs-site/src/content/docs/ja/reference/configuration/server.md 메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
|
Maintainer integration into dev under MAINTAINERS.md, bound to reviewed head All nine changed files were reviewed: eight apiKeys rows now correctly state data-plane-only admission, each locale management-reference link resolves at this tree, and the docs owner records the alignment. Runtime credentials/authentication are unchanged. No unresolved reviews or maintainer change requests were present. This is maintainer integration, not self-approval. Exact-head run https://github.com/lidge-jun/opencodex/actions/runs/35432368404 succeeded, including docs site build, structure gate and aggregate ci. The separate enforce-target gate also succeeded. Runtime jobs were not applicable to this documentation-only diff and are not claimed as executed. Local tests/typecheck/build/install were NOT RUN. Current base is dev; native-stack membership lookup returned empty. The unrelated runtime integration queue remains separately gated. Close #5120 only after confirmed dev landing. |
Summary
apiKeysserver-configuration row in English and all seven translated copies.Closes #5120
Verification
rg -n "apiKeys\\?" docs-site/src/content/docs/reference/configuration/server.md docs-site/src/content/docs/{fr,ja,ko,ru,tr,zh-cn,zh-tw}/reference/configuration/server.md— exactly one row per file (8 total).rg -n "management-api" ...on the same file set — every edited row links its locale management reference (8 hits on the edited rows).git diff --check— clean.Checklist