Skip to content

fix(release): support preview MSI and universal macOS packaging - #5526

Merged
lidge-jun merged 1 commit into
devfrom
codex/native-tray-release-platform-versions
Sep 22, 2026
Merged

lidge-jun merged 1 commit into
devfrom
codex/native-tray-release-platform-versions

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Sep 22, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Prepare both ARM64 and Intel Rust targets before building the universal macOS release app.
  • Generate a Windows-only WiX ProductVersion override from the validated numeric SemVer core. Public application/package/updater versions remain unchanged, so preview metadata is retained outside MSI.
  • Fix the concrete preview dry-run failures: missing x86_64-apple-darwin target and MSI rejecting preview.20260922. The pinned Tauri MSI template permits same-core replacement; manual MSI installs do not enforce same-core channel downgrade prevention.

Verification

  • Explicit Sol source/security review: PASS. Numeric bounds and SemVer parsing have committed regression cases; workflow wiring is covered by the existing release-script suite.
  • Local tests/typecheck/builds/probes: NOT RUN under user instruction. Canonical hosted dry-run remains the packaging/signing verification.
  • Immediate dev admin merge is owner-authorized without CI waiting. No pending check is claimed passed.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Summary by CodeRabbit

  • Bug Fixes

    • Improved Windows MSI release packaging to use validated numeric version information, including support for prerelease and build metadata.
    • Added safeguards for malformed or out-of-range installer versions.
  • Release Process

    • Updated desktop release builds to apply the generated Windows installer configuration automatically.
    • Updated macOS releases to install the required Rust targets.
  • Documentation

    • Clarified version handling and installer behavior for macOS and Windows releases.

@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner September 22, 2026 10:44
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: lidge-jun/opencodex/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 4326cbb3-c613-48fe-bb2d-08265acafdb4

📥 Commits

Reviewing files that changed from the base of the PR and between c37f4f5 and 357e073.

📒 Files selected for processing (4)
  • .github/workflows/release.yml
  • desktop/scripts/windows-installer-config.ts
  • structure/ops/docs-and-release.md
  • tests/ci-workflows/release-desktop-scripts.test.ts
 _________________________________________
< Because, faster merges = more features. >
 -----------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the bug Something isn't working label Sep 22, 2026
@lidge-jun
lidge-jun merged commit 482a3e0 into dev Sep 22, 2026
9 of 15 checks passed
@lidge-jun
lidge-jun deleted the codex/native-tray-release-platform-versions branch September 22, 2026 10:46
@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant