Skip to content

release(preview): carry verified checksum and signature repair - #5545

Merged
lidge-jun merged 1 commit into
previewfrom
codex/preview-release-verification
Sep 22, 2026
Merged

lidge-jun merged 1 commit into
previewfrom
codex/preview-release-verification

Conversation

@lidge-jun

Copy link
Copy Markdown
Owner

Summary

  • Repair the two producer/verifier mismatches blocking desktop publication. Standalone checksum filenames now retain the archive extension. The updater verifier now decodes Tauri's outer-base64 minisign box and verifies its ED/BLAKE2b-512 signature plus the trusted-comment signature against the pinned key.
  • Add an independent, attributed minisign 0.7.3 vector and rejection cases for altered payloads, signatures, comments, keys and malformed envelopes. Preserve asset counts, checksums, signature requirements and publication ordering.
  • Ten independent Sol reviewers inspect only this release-verification issue. Unrelated regression work is excluded. This is the owner-authorized preview promotion of merged dev PR fix(release): align checksum and Tauri signature verification #5544 (2b8b007). Channel versions are unchanged. The owner explicitly requested immediate integration and verification on main/preview only; dev CI is cancelled.

Verification

  • Hosted evidence: https://github.com/lidge-jun/opencodex/actions/runs/35721661559. All eight packaging jobs passed, including Apple notarization Accepted and bundle signature verification. Final verification failed on five checksum names.
  • Inspection of that run's actual MSI signature confirmed Tauri's four-line outer-base64 ED format. Pinned Tauri CLI 2.11.1 and minisign 0.7.3 source establish the prehash and global signature protocol.
  • Independent upstream test vector comes from jedisct1/rust-minisign commit 068d25a2fffd3d9da96e43f3844c830d8176d5a0 with its license retained.
  • Local tests, builds, typechecks and cryptographic execution: NOT RUN by owner instruction. Commit/push use --no-verify. Exact-head hosted tests and real artifact verification remain required; no source review is represented as an executed test.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner September 22, 2026 12:20
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Sep 22, 2026
@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: lidge-jun/opencodex/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: afad8573-5ef7-4bd3-984c-cd4e95e403de

📥 Commits

Reviewing files that changed from the base of the PR and between 7906a73 and 0c8c96b.

📒 Files selected for processing (7)
  • .github/workflows/release.yml
  • desktop/scripts/verify-release-assets.ts
  • structure/desktop-shell.md
  • tests/ci-workflows/release-desktop-scripts.test.ts
  • tests/ci-workflows/release-pipeline-contract.test.ts
  • tests/fixtures/minisign/LICENSE
  • tests/fixtures/minisign/prehashed-vector.json
 __________________________________________________________
< Solving problems you didn't know you were about to have. >
 ----------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lidge-jun
lidge-jun merged commit 57036a1 into preview Sep 22, 2026
14 of 29 checks passed
@lidge-jun
lidge-jun deleted the codex/preview-release-verification branch September 22, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant