Skip to content

test(providers): include GPT-6 Sol/Luna in the OpenAI API and DigitalOcean roster oracles - #5586

Merged
lidge-jun merged 1 commit into
devfrom
codex/gpt6-provider-rows-oracle
Sep 22, 2026
Merged

lidge-jun merged 1 commit into
devfrom
codex/gpt6-provider-rows-oracle

Conversation

@lidge-jun

Copy link
Copy Markdown
Owner

Summary

#5584 added GPT-6 Sol/Luna to the OpenAI API registry and to DigitalOcean's chat-completion allowlist. Two exact oracles still encoded the old rosters and failed on hosted CI for that PR (run 35771998809: test 2/4 and test 4/4):

  • codex-catalog.test.ts, "OpenAI API trusted catalog augmentation": the exactIds list lacked gpt-6-sol and gpt-6-luna, so three cases received two extra rows.
  • digitalocean-scaleway-provider.test.ts: the allowlist length assertion stayed at 27. The list now holds 29 ids; the comment's stale "28" is corrected as well.

Both are updated in place. codex-catalog.test.ts stays at its 7985-line cap.

Verification

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner September 22, 2026 19:19
@lidge-jun
lidge-jun merged commit 746c738 into dev Sep 22, 2026
6 of 7 checks passed
@lidge-jun
lidge-jun deleted the codex/gpt6-provider-rows-oracle branch September 22, 2026 19:19
@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature). label Sep 22, 2026
@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: lidge-jun/opencodex/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 5e8ceb1f-b6f2-4cbe-8acb-a8e57856969b

📥 Commits

Reviewing files that changed from the base of the PR and between 5dc4a40 and db73b41.

📒 Files selected for processing (2)
  • tests/codex-integration/codex-catalog.test.ts
  • tests/providers/digitalocean-scaleway-provider.test.ts
 ______________________________________________________________________________________________________
< What one programmer can do in one month, two programmers can do in two months. - Frederick P. Brooks >
 ------------------------------------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: db73b41e5f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

// assertion; Scaleway's happened to still match, so only this one went red - and it
// stayed red on dev, which is how a broken shard reached the branch that noticed it.
expect(digitaloceanModels).toHaveLength(27);
expect(digitaloceanModels).toHaveLength(29);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Assert the two new DigitalOcean model IDs

Increasing only the allowlist length does not verify the behavior this regression test claims to cover: if either openai-gpt-6-sol or openai-gpt-6-luna is misspelled or later removed while any unrelated model keeps the roster at 29 entries, this test still passes. A repository-wide search shows no other test asserting either DigitalOcean slug, so add explicit toContain checks for both IDs alongside the count.

AGENTS.md reference: AGENTS.md:L437-L441

Useful? React with 👍 / 👎.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-22T19:21:49.793835Z db73b41 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

void0x14 pushed a commit to void0x14/fucklidgejun that referenced this pull request Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant