Repository navigation
test(providers): include GPT-6 Sol/Luna in the OpenAI API and DigitalOcean roster oracles - #5586
Conversation
…Ocean roster oracles
|
✅ Deterministic PR hygiene checks passed. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: lidge-jun/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: db73b41e5f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // assertion; Scaleway's happened to still match, so only this one went red - and it | ||
| // stayed red on dev, which is how a broken shard reached the branch that noticed it. | ||
| expect(digitaloceanModels).toHaveLength(27); | ||
| expect(digitaloceanModels).toHaveLength(29); |
There was a problem hiding this comment.
Assert the two new DigitalOcean model IDs
Increasing only the allowlist length does not verify the behavior this regression test claims to cover: if either openai-gpt-6-sol or openai-gpt-6-luna is misspelled or later removed while any unrelated model keeps the roster at 29 entries, this test still passes. A repository-wide search shows no other test asserting either DigitalOcean slug, so add explicit toContain checks for both IDs alongside the count.
AGENTS.md reference: AGENTS.md:L437-L441
Useful? React with 👍 / 👎.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…Ocean roster oracles (lidge-jun#5586)
Summary
#5584 added GPT-6 Sol/Luna to the OpenAI API registry and to DigitalOcean's chat-completion allowlist. Two exact oracles still encoded the old rosters and failed on hosted CI for that PR (run 35771998809:
test 2/4andtest 4/4):codex-catalog.test.ts, "OpenAI API trusted catalog augmentation": theexactIdslist lackedgpt-6-solandgpt-6-luna, so three cases received two extra rows.digitalocean-scaleway-provider.test.ts: the allowlist length assertion stayed at 27. The list now holds 29 ids; the comment's stale "28" is corrected as well.Both are updated in place.
codex-catalog.test.tsstays at its 7985-line cap.Verification
Checklist