Repository navigation
test(claude): skip POSIX mode checks for picker files on Windows - #5734
Conversation
The Desktop picker tests added in #5728 assert 0o600 on the profile, state and model snapshot files. Windows reports 0o666 for any writable file, so windows 3/9 and 4/9 failed on dev (ci.yml lane=all run 35957063545) with "Expected: 384, Received: 438". Guard the three assertions the same way claude-picker-ca.test.ts guards its key file.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: lidge-jun/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
ci.yml lane=allondev(run 35957063545 at 8b562bf) failedwindows 3/9andwindows 4/9on two tests that #5728 added:claude-desktop-picker-profile.test.ts:creates an egress-only row, records the prior selection, and is idempotentclaude-picker-models.test.ts:snapshot persists mode 0600, loads synchronously, and retains last good on loader failureBoth failed with
Expected: 384 (0o600), Received: 438 (0o666). Windows has no POSIX permission bits, sostat().modereports 0o666 for every writable file. The three mode assertions now run only off Windows, the same wayclaude-picker-ca.test.ts:104already guards its key file. Every other assertion in both tests still runs on every platform.Verification
bun test tests/claude-integration/claude-picker-models.test.ts tests/claude-integration/claude-desktop-picker-profile.test.ts: 9 pass, 0 fail.bun run typecheck: pass.git diff --check: clean.ci.yml lane=allondevafter merge (the owner verifies ondev).Checklist