Skip to content

test(claude): skip POSIX mode checks for picker files on Windows - #5734

Merged
lidge-jun merged 1 commit into
devfrom
codex/260924-picker-profile-windows-mode
Sep 24, 2026
Merged

lidge-jun merged 1 commit into
devfrom
codex/260924-picker-profile-windows-mode

Conversation

@lidge-jun

Copy link
Copy Markdown
Owner

Summary

ci.yml lane=all on dev (run 35957063545 at 8b562bf) failed windows 3/9 and windows 4/9 on two tests that #5728 added:

  • claude-desktop-picker-profile.test.ts: creates an egress-only row, records the prior selection, and is idempotent
  • claude-picker-models.test.ts: snapshot persists mode 0600, loads synchronously, and retains last good on loader failure

Both failed with Expected: 384 (0o600), Received: 438 (0o666). Windows has no POSIX permission bits, so stat().mode reports 0o666 for every writable file. The three mode assertions now run only off Windows, the same way claude-picker-ca.test.ts:104 already guards its key file. Every other assertion in both tests still runs on every platform.

Verification

  • bun test tests/claude-integration/claude-picker-models.test.ts tests/claude-integration/claude-desktop-picker-profile.test.ts: 9 pass, 0 fail.
  • bun run typecheck: pass. git diff --check: clean.
  • The Windows proof is ci.yml lane=all on dev after merge (the owner verifies on dev).

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

The Desktop picker tests added in #5728 assert 0o600 on the profile, state and
model snapshot files. Windows reports 0o666 for any writable file, so
windows 3/9 and 4/9 failed on dev (ci.yml lane=all run 35957063545) with
"Expected: 384, Received: 438". Guard the three assertions the same way
claude-picker-ca.test.ts guards its key file.
@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner September 24, 2026 05:09
@lidge-jun
lidge-jun merged commit 359616e into dev Sep 24, 2026
6 of 7 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-24T05:11:18.274664Z 7e3fcc3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@lidge-jun
lidge-jun deleted the codex/260924-picker-profile-windows-mode branch September 24, 2026 05:09
@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature). label Sep 24, 2026
@coderabbitai

coderabbitai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: lidge-jun/opencodex/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: f24ad829-bf6c-402c-8fa0-02be093808a3

📥 Commits

Reviewing files that changed from the base of the PR and between 8b562bf and 7e3fcc3.

📒 Files selected for processing (2)
  • tests/claude-integration/claude-desktop-picker-profile.test.ts
  • tests/claude-integration/claude-picker-models.test.ts
 __________________
< I see dead code. >
 ------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant