Repository navigation
test(windows): keep the badge tick budget off the offline health request - #5772
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: lidge-jun/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
windows 6/9fails on everydevrun since #5765:Windows tray packaging and command safety > terminates and later reaps hung, overflowing, or failed tray probes without stackingreportsBadgeOffline: UI tick blocked(864 ms in run 36031544236, 936 ms in run 36034025682; bound 250 ms).The driver times the whole
Update-TrayStatetick, which starts with the pre-existing/healthzrequest (Read-JsonUrl, 700 ms timeout). On an offline Windows runner a refused loopback connect can take most of a second, so the badge scenarios were measuring that request rather than the update-badge maintenance #5765 added. For theBadge*scenarios only, the driver now answers/healthzoffline instantly; the Offline and Online scenarios keep the real request. The tray script is unchanged, and the 250 ms bound still applies to the badge maintenance.Verification
tests/windows/windows-tray.test.ts:614) andsrc/tray/windows-tray.ps1(Update-TrayState→Read-JsonUrl→Maintain-UpdateBadgeProbe).devCross-platform CI run (lane=all) dispatched after merge.Checklist