Skip to content

test(windows): keep the badge tick budget off the offline health request - #5772

Merged
lidge-jun merged 1 commit into
devfrom
codex/260925-fix-badge-tick-budget
Sep 24, 2026
Merged

lidge-jun merged 1 commit into
devfrom
codex/260925-fix-badge-tick-budget

Conversation

@lidge-jun

Copy link
Copy Markdown
Owner

Summary

windows 6/9 fails on every dev run since #5765: Windows tray packaging and command safety > terminates and later reaps hung, overflowing, or failed tray probes without stacking reports BadgeOffline: UI tick blocked (864 ms in run 36031544236, 936 ms in run 36034025682; bound 250 ms).

The driver times the whole Update-TrayState tick, which starts with the pre-existing /healthz request (Read-JsonUrl, 700 ms timeout). On an offline Windows runner a refused loopback connect can take most of a second, so the badge scenarios were measuring that request rather than the update-badge maintenance #5765 added. For the Badge* scenarios only, the driver now answers /healthz offline instantly; the Offline and Online scenarios keep the real request. The tray script is unchanged, and the 250 ms bound still applies to the badge maintenance.

Verification

  • Diagnosis from the two failed job logs (tests/windows/windows-tray.test.ts:614) and src/tray/windows-tray.ps1 (Update-TrayState → Read-JsonUrl → Maintain-UpdateBadgeProbe).
  • Windows-only test; verified by the dev Cross-platform CI run (lane=all) dispatched after merge.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed. (Test-only change.)
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults. (None touched.)

@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner September 24, 2026 17:46
@lidge-jun
lidge-jun merged commit 5cdd97e into dev Sep 24, 2026
5 of 6 checks passed
@lidge-jun
lidge-jun deleted the codex/260925-fix-badge-tick-budget branch September 24, 2026 17:46
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-24T17:48:19.988964Z 17d750e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature). label Sep 24, 2026
@coderabbitai

coderabbitai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: lidge-jun/opencodex/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 277011d8-1035-4c2b-b6a1-2f69218312fe

📥 Commits

Reviewing files that changed from the base of the PR and between 8755077 and 17d750e.

📒 Files selected for processing (1)
  • tests/helpers/windows-tray-probe-lifecycle-driver.ps1
 ___________________________________________________________________
< That's not a helper function. That's a co-dependent relationship. >
 -------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant