Repository navigation
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 9 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. Review configuration: ⚙️ Run configurationConfiguration used: Repository: lidge-jun/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: lidge-jun/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (7)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe ChangesCapabilities argument validation
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The capabilities command distinguishes invalid usage from a valid query with no matches. No actionable merge-blocking issue is established; complete the planned CI validation before merging. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 5 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (5 skipped: 5 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Review readiness checklist
0/4 boxes ticked. This PR stays in draft until every box above is ticked. |
|
Please review the current head @coderabbitai review @codex review |
✅ Action performedReview finished.
|
|
Batch intake for the ten independent drafts #6429 and #6431–#6439: I read their complete changed-file patches, including both test-layout registrations and EN/KO contract additions, and authorized the existing read-only GitHub-hosted CI at each immutable current head. No workflow/dependency/install changes are included in these diffs. That authorizes execution only, not PR approval or a readiness waiver. The shared Windows layout-guard failures in Verification remain recorded as failures; their attribution to EPERM/checkout contamination needs a clean exact-head result, not deletion of the guard or an increased budget. Please keep the drafts until the corrected/current validation is established, and keep just one canonical readiness checklist per description (currently duplicated). Before integration, reconcile the overlapping single-line edits in runtime/config/usage structure docs and the shared observe.ts consumers; green standalone heads do not establish their combined tree. I have not run ten full local suites or a security scan, and do not claim the author-local red/green results as independently rerun tests. |
|
Please review the current head @coderabbitai review @codex review |
|
…6431 #6432 #6433 #6434 #6435 #6437 #6438) (#6447) * fix(cli): reject ignored capabilities arguments (carry #6429) Carries #6429 by @oocheol onto current dev as part of the oocheol CLI batch. Co-authored-by: 정우철 <oocheol@naver.com> * fix(cli): reject ambiguous and unsafe integer options (carry #6431) Carries #6431 by @oocheol onto current dev as part of the oocheol CLI batch. Co-authored-by: 정우철 <oocheol@naver.com> * fix(cli): accept UTF-8 BOM in imported config files (carry #6432) Carries #6432 by @oocheol onto current dev as part of the oocheol CLI batch. Co-authored-by: 정우철 <oocheol@naver.com> * fix(cli): validate setup ports before saving config (carry #6433) Carries #6433 by @oocheol onto current dev as part of the oocheol CLI batch. Co-authored-by: 정우철 <oocheol@naver.com> * fix(cli): support JSON output on the default alias command (carry #6434) Carries #6434 by @oocheol onto current dev as part of the oocheol CLI batch. Co-authored-by: 정우철 <oocheol@naver.com> * feat(cli): show request IDs in human log output (carry #6435) Carries #6435 by @oocheol onto current dev as part of the oocheol CLI batch. Co-authored-by: 정우철 <oocheol@naver.com> * fix(cli): return not-found for missing routing profiles (carry #6437) Carries #6437 by @oocheol onto current dev as part of the oocheol CLI batch. Co-authored-by: 정우철 <oocheol@naver.com> * fix(responses): keep usable fallback upstream error messages (carry #6438) Carries #6438 by @oocheol onto current dev as part of the oocheol CLI batch. Co-authored-by: 정우철 <oocheol@naver.com> * fix(cli): ask for the setup port again instead of abandoning ocx init Amends the #6433 carry: an invalid interactive port now reports the error and re-asks, so a typo no longer discards every earlier answer. EOF and SIGINT at the repeated prompt still cancel without saving (exit 1 / 130); the wizard tests cover all three paths. Co-authored-by: 정우철 <oocheol@naver.com> * test(responses): pin recovery consumers of the upstream message fallback Follow-up to the #6438 carry: encrypted-output resend and quota alternate-account detection now see a fallback message hidden behind a blank primary one; a nonblank primary still wins. Co-authored-by: 정우철 <oocheol@naver.com> * docs(cli): separate the carried reference sections Co-authored-by: 정우철 <oocheol@naver.com> * chore: keep the lane plan record out of the carry --------- Co-authored-by: 정우철 <oocheol@naver.com>
Summary
8b23fe340a53799aac5ad7654582a75df7ade7c8; this PR contains only this change.Verification
Validated on Windows with Bun 1.4.0 at current head
ed898c241f76b586061dcba54a2ba51158584b10. The layout and file-size guards run from a fresh worktree with the default test budget; no guard, fixture directory, baseline cap, or timeout was changed.bun run scripts/test.ts tests/cli/cli-capabilities-arguments.test.ts tests/cli/cli-capabilities.test.ts: PASS, 26 pass / 0 fail.bun node_modules/typescript/bin/tsc --noEmit: PASS, exit 0.bun scripts/structure-ssot.ts: PASS, exit 0.bun scripts/privacy-scan.ts: PASS, exit 0.bun run scripts/test.ts tests/test-layout.test.ts tests/test-layout-tooling.test.ts tests/ci-workflows/file-size-ratchet.test.ts: PASS, 27 pass / 0 fail.The first validation from the original Windows checkout failed on a pre-existing EPERM fixture directory and, in some runs, a five-second subprocess timeout. Those attempts remain historical failures; the fresh-worktree current-head guard result above replaces neither the failure record nor a required CI run. The first cold file-size scan for #6429 also exceeded five seconds, then passed at the same head on the same default budget. No inaccessible fixture was deleted and no test budget was raised.
Integration validation used actual local merges of all ten PR heads onto dev
03ed9a3b1c1535d25f8f47c3d6bf38db8ffc1fc9(local-only assembled commitdd7d1fe254c3fc86144a2c3cce0ae483332b55bb). Owner-contract edits in runtime/config/usage now merge independently; shared observe.ts consumers merge without a source conflict. Additive EN/KO document-append conflicts and test-map insertion conflicts were reconciled by retaining both sections/registrations, not choosing one PR over another.Full
bun run testandbun run test:changedremain unrun: nine small independently validated revisions plus a combined 24-file run share one Windows machine, so repeated full repository runs on each draft would be disproportionate. The explicit regression files cover the touched behavior and source-oracle consumers; broader platform/integration coverage remains for exact-head CI. Updated-head CI and automated review must be confirmed separately; older-head results, queued jobs, skipped jobs, and approval-pending runs are not passing evidence.Review response: Added a docstring to the capabilities command entry point. Added function documentation addresses the warning in source; the remote coverage percentage is not claimed as rerun. All descriptions retain only the gate-managed canonical readiness checklist.
Checklist
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
Required local validation passed; commands, results, and any full-suite exception are documented.
I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.
Summary by CodeRabbit
ocx capabilitiescommand now rejects unknown or repeated flags, extra arguments, and blank--routevalues with exit code 64.