Repository navigation
test(link): isolate the remote-prelude tests from a host-installed ocx - #6787
Conversation
Carries #6726 so it runs under repository CI. Co-authored-by: Sungyong Cho <dev@sungyongcho.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughTwo SSH argument tests now use a temporary remote PATH containing only a ChangesRemote PATH test isolation
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other · Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to The change isolates the SSH argument tests from host-installed 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Carries #6726 by @sungyongcho so it runs under repository CI (fork CI needs maintainer approval).
Two tests in
tests/clients/link-ssh-argv.test.tsfail on any host that already hasocxin/usr/bin, such as a machine with the OpenCodex desktop .deb. Both simulate the remote PATH as/usr/bin:/binand expect the stub in~/.bun/binto run. The remote prelude appends~/.bun/binafter the remote PATH on purpose, so a hostocxwins and the stub never runs.The two tests now use a remote PATH that holds only an
shsymlink to/bin/sh. The first test's expected PATH line follows the new base. Production code and the other tests are unchanged; the ordering contract stays enforced by the literal prelude assertion and the "an ocx the remote PATH already resolves wins" test.Closes #6726 once landed (the source PR is closed manually after this merges).
Verification
bun test tests/clients/link-ssh-argv.test.tson macOS with brokenocxshims on PATH: 18 pass, 1 skip (the Windows-only PowerShell case), 0 fail.REMOTE_OCX_SCRIPTinsrc/link/ssh-argv.tsto prepend the fallback directories makes 3 tests fail (prelude literal, append ordering, remote-PATH ocx wins); restored afterwards.c15037b324...1878576851: PASS.Checklist
Co-authored-by: Sungyong Cho dev@sungyongcho.com
Summary by CodeRabbit