Repository navigation
fix(oauth): preserve operator model policy across reconciliation - #7141
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 13
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
|
Maintainer integration into
|
Summary
Closes #7092.
modelReasoningEffortsAuthoritative: trueexplicitly retains operator ladders over seeded rows. The existing Grok stale-ladder refresh regression remains intact.Saved operator maps and previously materialized preset maps have no separate provenance. Existing entries are retained; future corrections to an already-saved seed require an explicit migration. Live discovery and request-time admission retain their existing limits.
Security review: explicit maintainer security review is required before merge under MAINTAINERS.md because this touches OAuth config upsert. Independent static review found no blocking correctness/security issue. Credential handling, login-owned destinations, account selection and key-retention rules are unchanged.
Verification
All runtime checks used temporary
OPENCODEX_HOMEandCODEX_HOMEdirectories. No real accounts or user configuration were read or changed.bun install— PASS; no dependency/lockfile changes.bun test tests/oauth/oauth-reconcile-operator-maps.test.ts tests/oauth/oauth-provider-reconcile.test.ts tests/oauth/oauth-upsert-preserves-api-key.test.ts— 65 pass, 0 fail..tmp/7092/runner/bun-darwin-aarch64/bun test tests/oauth/oauth-reconcile-operator-maps.test.ts tests/providers/model-rename-migration.test.ts(pinned Bun 1.4.3, after review fixes) — 62 pass, 0 fail.bun test tests/oauth/oauth-reconcile-operator-maps.test.ts— 1 pass, 11 fail before the final authoritative-ladder case was added; Copilot and xAI cases both reproduced the defect. Source was restored immediately afterward.bun run typecheck— PASS.bun run structure:check— PASS.bun run privacy:scan— PASS.bun test tests/test-layout.test.ts tests/test-layout-tooling.test.ts tests/ci-workflows/file-size-ratchet.test.ts— 35 pass, 1 fail on host Bun 1.4.0: the remaining tooling test requires the repository's Bun 1.4.3 pin. Running that test directly with the pin resolved it:.tmp/7092/runner/bun-darwin-aarch64/bun test tests/test-layout-tooling.test.ts -t 'domain verification launches isolate tests through the pinned runner'— 1 pass, 0 fail (24 filtered out). The earlier attempt to useOCX_TEST_RUNNER_BUNwhile running Bun 1.4.0 also failed because this test mocks the version probe; no source changes were made to bypass it.(cd docs-site && bun install --frozen-lockfile)and(cd docs-site && bun run build)— PASS; 577 pages, 81,200 internal links checked.git diff --cached --check— PASS.The maintainer explicitly prohibits heavy/full local suites on this shared host.
bun run test,bun run prepush, and the whole tests directory were NOT RUN. Broad validation is left to PR CI's fast Ubuntu subset and a subsequent manualci.ymldispatch withlane=allon this branch. CI results will be recorded against the exact pushed head.Checklist
CI snapshot refreshed for head
0b13b47530ee5ee0804745eaa324fbbd254992d5(2026-10-15): PR CI run SUCCESS. Test shards 1/4–4/4, storage policy, API usage, gates, Ubuntu keyring/npm-global, Docker smoke, docs site build, structure gate and aggregate ci all succeeded. Catalog async contracts, hygiene, React Doctor, label and CodeRabbit also succeeded. Latest enforce-target remains QUEUED; older cancelled attempts are not treated as passing evidence. Test-step execution was verified for shards 1 and 2.A full cross-platform workflow_dispatch run already exists for this exact head; initial changes and Windows-runner selection jobs are QUEUED. No duplicate dispatch was started. The prior dispatch was CANCELLED and supplies no passing evidence. Full cross-platform validation and explicit maintainer security review remain outstanding.