Repository navigation
feat(codex): allow explicit custom provider routing consent - #7172
Closed
xianlubird wants to merge 3 commits into
Closed
xianlubird wants to merge 3 commits into
xianlubird wants to merge 3 commits into
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
✅ Deterministic PR hygiene checks passed. |
Add explicit home-bound, per-provider consent for URL-only local routing. Preserve provider identity and transport settings, recover original URLs on restore and foreground exit, and recognize recorded routes in startup health. Retain recovery/concurrency/teardown coverage from the existing PR updates. Consolidates the original feature and the following follow-up commits: e54d978 b195436 3ccc6fa 1d8026d 160a6db f7d5bf1 Co-authored-by: GOAT <goat@localhost> Signed-off-by: xianlubird <xianlubird@gmail.com>
xianlubird
force-pushed
the
feat/codex-provider-consent
branch
from
October 15, 2026 12:16
f7d5bf1 to
b588672
Compare
Contributor
⏳ DRAFT
What to do
Review readiness checklist
0/4 boxes ticked. This PR stays in draft until every box above is ticked. |
added 2 commits
October 16, 2026 00:56
# Conflicts: # scripts/test-layout/layout.json # structure/runtime.md
# Conflicts: # structure/INDEX.md
2 of 3 tasks
Owner
|
Being carried into #7222 with your authorship preserved; this PR will be closed when the bundle lands. |
lidge-jun
added a commit
that referenced
this pull request
Oct 16, 2026
…trols (#7211, #7212, #6381, #7172, #6152) (#7222) Carried from #7211, #7212 (both opened against main; carried onto dev), #6381, #7172, #6152 (one commit per source PR, original authors preserved). Custom provider routing consent defaults to No and the CLI update plan is read-only. Remote validation (hosted test shards passed on the head; local tests not run by maintainer rule): exact head b4d6376 (contains dev 7a42860) typecheck + full suite on lidge (Linux) and mini (Windows), compared with the same host's dev 7a42860 runs. Security review of the #7172/#6152 carries: PASS. Co-authored-by: Matt Van Horn <mvanhorn@users.noreply.github.com> Co-authored-by: lcxhh <lcxhh521@gmail.com> Co-authored-by: xianlubird <xianlubird@gmail.com> Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com>
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A custom Codex provider created only to disable WebSocket transport is currently treated as externally managed, so OpenCodex skips routing injection and users must edit its URL manually.
Add
ocx codex-provider allow <id>with a default-No confirmation (or explicit per-ID--yes), plusstatusandrevoke. Consent is scoped to the selected Codex home and provider ID. Start/sync manages only the approved provider'sbase_url; its ID, WebSocket setting, other fields and conversation history are preserved. Stop/restore and foreground signal/exit cleanup restore the original URL. Consent persists until revoked.Private recovery metadata is published before URL changes, URL drift requires renewed consent, and concurrent writers use the existing locks. Startup diagnostics recognize only approved URLs recorded as managed by OpenCodex; service/shim availability still determines restart safety. The initial scope is loopback Responses routing with OpenAI authentication and no separate credentials/headers. Admission-token targets, authless Desktop mode and client compaction are explicitly refused.
The branch is based on the current
devbaseline. Existing follow-up recovery/concurrency/foreground-exit work is retained, with original commit IDs and coauthor attribution preserved in the signed consolidation commit. CLI help, generated operating references and user/architecture docs are updated.Verification
No local tests were run for this rewritten head, at the requester's explicit instruction to leave testing to CI. New and retained regressions cover consent and URL drift, restore/revocation, cross-home isolation, startup ownership classification, concurrent writers, process interruption and launcher teardown. CI validation of the current head remains pending; this PR stays a draft.
Historical results from earlier heads, not passing evidence for this rewritten head:
bun run test:changedselected 1,328 files, encountered sandbox loopback-listener errors and was stopped. A subsequent retry was stopped at the requester's instruction. Neither is claimed as passing.The consolidated commit has a DCO sign-off and a GitHub-verified SSH signature. No provider consent, credential, user configuration or service was modified as part of the branch rewrite.
Checklist
Review readiness
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
Required local validation passed; commands, results, and any full-suite exception are documented.
I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.