Repository navigation
test(temp): compare the default containment result through the native resolver - #7361
Conversation
… resolver The #7359 default-resolver case compared realpathSync.native output with a fixture path resolved by the JS realpath, which keeps the 8.3 RUNNER~1 spelling on hosted Windows (run 39215956943, windows 9/9).
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
|
✅ Deterministic PR hygiene checks passed. |
Summary
#7359 added
final EPERM quarantine > containment resolves TEMP with the 8.3-expanding native resolver by default, which fails on hosted Windows (dev ee3ad33, run 39215956943, windows 9/9, job 117939835484):The product behaved as intended: the default resolver expanded the 8.3 alias. The test's expectation,
fixture.runTmp, comes fromcontainedFixture(), which resolves with JSrealpathSyncand keeps theRUNNER~1spelling. The expectation is nowrealpathSync.native(fixture.runTmp), computed before the spy is installed, so both sides go through the same native resolver. The spy assertion that pinsrealpathSync.nativeas the default is unchanged.I checked the other #7359 case (
an 8.3 TEMP alias still contains the long-form locked path) and the shared fixtures. That case runs both sides through its injected resolver and compares against JS-resolved fixture paths consistently, which is why it passed on the same Windows job. No other assertion mixes the two resolvers.Verification
bun test tests/ci-workflows/test-temp-quarantine.test.ts: 10/10 pass (macOS, where the two resolvers agree).Checklist
Summary by CodeRabbit
TEMPinput.