[lidge-jun]

Summary

The Windows-sensitive diff selector (scripts/ci/windows-sensitive-diff.sh) missed process-signal code. #7484 added a test asserting POSIX signal semantics (SIGKILL after SIGTERM). On Windows, kill("SIGTERM") is TerminateProcess, so the test failed on dev lane=all (windows 4/9, run 39693529639). The selector never flagged #7484, so nobody dispatched lane=all before merge. #7502 fixes the test itself.

This adds three fixed grep -F content markers: sigterm, sigkill and process.kill. They use the selector's existing lowercase matching. A diff that adds process-signal code now reports windows-sensitive: true, and that shows the existing notice: dispatch lane=all before merge.

Security note: this is a notice-only change to a CI selector script. CI policy is unchanged: PR CI still runs no Windows jobs (AGENTS.md owner CI policy), and no workflow permissions, triggers or job conditions change.

Verification

• bun test tests/ci-workflows/: 1637 pass, 10 skip, 0 fail (local, macOS).
• New scenarios in tests/ci-workflows/ci-review-lanes.test.ts show that a diff adding child.kill("SIGTERM"), a "SIGKILL" assertion or process.kill(pid, 0) yields true. The existing negative scenarios still yield false.
• The PR touches scripts/ci, so it is Windows-sensitive itself. A ci.yml lane=all dispatch on the exact head is required before merge.

Checklist

• Targets dev
• Tests added for the new behavior
• No CI policy change (notice-only)
• No secrets or account identifiers

Summary by CodeRabbit

• Chores
  • Expanded CI checks to flag added code using Windows-sensitive process termination signals and process.kill calls.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	🔄 Running since 2026-10-22T03:04:01.737761Z	d8c4665	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[coderabbitai]

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

• Configuration used: Repository: lidge-jun/opencodex/.coderabbit.yaml
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 3a798344-d4f3-41aa-b7cf-5c2c7fe30496

📥 Commits

Reviewing files that changed from the base of the PR and between d8c4665 and c31b08f.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: lidge-jun/opencodex/.coderabbit.yaml
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: cf30d3b5-ed64-443e-99e3-696aa29aee6b

📥 Commits

Reviewing files that changed from the base of the PR and between a4f335c and d8c4665.

📒 Files selected for processing: 2

• scripts/ci/windows-sensitive-diff.sh
• tests/ci-workflows/ci-review-lanes.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.

📝 Walkthrough

The Windows-sensitive diff scan now recognizes sigterm, sigkill, and process.kill in added lines. Tests cover these markers in source and test paths.

Changes: Windows diff scan

Layer / File(s)	Summary
Process-signal markers and test cases scripts/ci/windows-sensitive-diff.sh, tests/ci-workflows/ci-review-lanes.test.ts	The marker list adds sigterm, sigkill, and process.kill. Test cases expect the scan to match added lines containing these operations in the specified source and test paths.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to d8c46

The selector change is mergeable; it adds the intended advisory without altering CI job selection.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: updating CI to flag process-signal code as Windows-sensitive.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files.

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

✅ Deterministic PR hygiene checks passed.

[lidge-jun]

Merged with owner authority per maintainer decision 2026-10-21 (jun): the project owner authorized owner-path (--admin) merges for the pending green PRs after the 2.90.0 release; no second-maintainer approval is available.

Exact-head verification on c31b08f430346b92b3d37ed0f2032aa824374359: all checks completed with no failures, the PR is mergeable, there are no change requests, and no unresolved current Major/Critical/P0/P1 review threads. A local squash of this head onto current dev fc034c84c passed typecheck, structure:check, the file-size, import-cycle and test-layout ratchets, and this PR's own tests ( 164 pass 0 fail ). Windows-sensitive: true (Cross-platform CI lane=all on this head: https://github.com/lidge-jun/opencodex/actions/runs/39720859021); PR CI never runs Windows (AGENTS.md CI policy), so a Windows-sensitive PR merges only after a green lane=all dispatch. The merge is a squash pinned with --match-head-commit.

[lidge-jun]

Windows verdict detail: lane=all run 39720859021 failed once, only in windows 2/9. The failure was an EPERM removing the temp dir during tests/server/server-management-auth.test.ts teardown, which this PR doesn't touch; it is tracked in #7515. Rerunning only that job on the same head passed, so the run concluded success (34/34) on c31b08f43.