Repository navigation
Conversation
Apply citation repair in the native compact send builder after queued provider refresh. Preserve original gateway annotations while retaining repair for official OpenAI API and ChatGPT sends. Cover both destination transitions, exact annotation preservation, independent metadata stripping, and native positive controls. Document the destination boundary in the public adapter reference and structure contracts.
…rk752-dev-bd5-20261024
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
…tation-rewrite-for-third-party-gateways # Conflicts: # tests/claude-integration/claude-picker-upload.test.ts
|
Integration evidence (owner decision decision:b607a677, approved): independent gpt-6.1-sol review PASS at 2c15cdc; the current head efe32b5 only adds a merge of origin/dev (after #7666 touched the structure index). Exact-head PR CI run 40170366546 and exact-head ci.yml lane=all run 40170382657 both succeeded. Static merge simulation on current dev a589dde (this Mac): dev=a589dde00e438d27c881d018fe926dfda3f81a33 base=6672cfb4a2b9a1dc72e26ed159c1d70368fe0ca7 pr_files= 12 overlap=[]; merge clean; install exit=0; gui install exit=0; tsc exit=0; tsc doctor exit=0; structure:check exit=0; privacy:scan exit=0; layout+ratchet guards exit=0 54 pass 0 fail ; Merged by the triage manager as maintainer integration (MAINTAINERS.md, dev only) with green exact-head PR CI, an independent review PASS, and the owner's approval of this bundle. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
Native compact currently repairs URL citations before the final destination is known. This changes annotations owned by custom gateways and can apply the wrong policy if key admission refreshes the provider before sending.
Verification
Candidate
beec3e4342c077a595ddd94b93d45b7f2a2eb69anormally mergesdev@0aeaf0cb6b0a7c2f117d8c75f8fa396cf2ea6e39and shared #7627 (f011a94be1b468b7b785cb54976d4cb4a9b6a563). Runtime andtestRunnerBunare both pinned to 1.4.4. The PR remains based ondev.Current candidate validation: Official native Windows Bun 1.4.4,
CI=true bun test --isolate --timeout 60000, fresh processes for the four focused citation/compact files: 40 passed / 0 failed / 0 skipped / 401 assertions. Reference TypeScript, official Structure and skill-surface checks, and all 23 changed-file privacy/size/diff checks passed. All eight units returned native exit 0 and complete child output; matching installed dependencies were reused without reinstalling.The source refresh preserves the 12-file citation change and adds the shared 11-file Bun baseline. Runtime and regression-test blobs are preserved; Structure metadata also retains current dev's provider documentation. No GUI change.
Previously reported at
51e214ebbe8d347b17eb6c39b9f028e91f40f34a: official Bun 1.4.4 on Windows passed 40 tests / 0 failures / 401 assertions across compact key selection, native-item extensions for compact and ordinary requests, and URL-citation repair. These used pure builders and injected fetch fixtures, with no live provider calls. Root TypeScript, Structure, changed-file privacy/size and diff checks also passed at that earlier head; they do not validate this refreshed candidate.The full local suite was not run under the shared-worktree resource exception. Broader coverage and the updated hosted documentation build remain pending for the final head. Keep this PR draft until the required validation is complete.
Checklist