Skip to content

feat(claude): opt out of native/* in Claude Desktop model list - #783

Closed
Wibias wants to merge 2 commits into
lidge-jun:devfrom
Wibias:fix/767-desktop-native-models
Closed

Wibias wants to merge 2 commits into
lidge-jun:devfrom
Wibias:fix/767-desktop-native-models

Conversation

@Wibias

@Wibias Wibias commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes #767

Opts Claude Desktop model list out of native/* entries.

Test plan

  • bun run typecheck
  • bun run test

@coderabbitai

coderabbitai Bot commented Jul 30, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@Wibias, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 34 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c19a81e4-0a6e-46af-b7b1-f0bce8a22025

📥 Commits

Reviewing files that changed from the base of the PR and between be177ea and 5aff2ab.

📒 Files selected for processing (9)
  • src/cli/claude-desktop.ts
  • src/codex/catalog.ts
  • src/codex/catalog/metadata.ts
  • src/server/index.ts
  • src/server/management/agent-settings-routes.ts
  • src/server/management/shared.ts
  • src/types.ts
  • tests/claude-desktop-cli.test.ts
  • tests/grok-management-api.test.ts

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 260efcfc2a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/server/management/shared.ts Outdated
Comment thread src/cli/claude-desktop.ts
@github-actions github-actions Bot added the enhancement New feature or request label Jul 30, 2026
@Wibias

Wibias commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

[shipping-github] Merge-ready

CI green on \ ix/767-desktop-native-models\ (Cross-platform CI, enforce-target, react-doctor). No open review threads. Targets \dev\ for #767.

Keep Grok candidate natives on visibleNativeSlugs and filter Anthropic Desktop discovery through desktopVisibleNativeSlugs.
@Wibias

Wibias commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

Verdict: approve-comment

@lidge-jun

Copy link
Copy Markdown
Owner

Landed on codex/260731-pr-merge-round, squashed with your authorship preserved. That branch is a staging line: it merges into dev and ships once the performance work in flight there lands.

f72610027 — landed unchanged.

What made this reviewable was applying the gate at every Desktop surface that emits the list — discovery and profile export both — rather than only the one the report happened to name. Keeping Grok natives is also the right call: they are reachable through Desktop, so hiding them would have removed working models.

The regression test fails without the change by finding native/* in both the show and export output, which is what a config-flag test should do.

#767 closed alongside.

@lidge-jun lidge-jun closed this Jul 31, 2026
@Wibias
Wibias deleted the fix/767-desktop-native-models branch July 31, 2026 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants