staticaddr/deposit: preserve confirmation heights - #1219
Open
hieblmi wants to merge 1 commit into
Open
Conversation
hieblmi
force-pushed
the
fix/static-deposit-confirmation-height
branch
from
August 31, 2026 10:16
577bc1c to
053004f
Compare
Bracket wallet UTXO queries with matching chain-synced lnd tips before converting confirmation counts into absolute heights. Defer expiry and spending decisions while the wallet is catching up, and cap queued expiry notifications at the reconciled tip.
hieblmi
force-pushed
the
fix/static-deposit-confirmation-height
branch
from
August 31, 2026 10:37
053004f to
9c14505
Compare
Collaborator
Author
|
/gateway review |
|
👀 gateway review starting… |
Collaborator
Author
|
/gateway re-review |
|
gateway is not active on this PR. Run |
Collaborator
Author
|
/gateway review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Static Address deposit reconciliation previously combined queued block epochs with wallet confirmation counts from a different lnd sync point. During rapid lnd catch-up this repeatedly rewrote the persisted first-confirmation height and could make expiry appear eligible one block early.
This change brackets each wallet UTXO query with matching, chain-synced lnd tip observations before deriving absolute confirmation heights. It also:
Stack order (bottom to top / merge order):
9c145058) — confirmation-height preservation (this PR), based onmaster.c74ac6cd) — multi-address core, stacked on this PR.8ab455f9) — withdrawal hardening, stacked on staticaddr: support multiple receive and change addresses #1218.Testing: