chore: Sync account schemas - #881
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
✱ Stainless preview builds for gridThis PR will update the cli kotlin php ruby Edit this comment to update them. They will appear in their respective SDK's changelogs. ⏳ grid-typescript studio⏳ grid-openapi studio⏳ grid-ruby studio⏳ grid-kotlin studio⏳ grid-go studio⏳ grid-python studio⏳ grid-php studio⏳ grid-cli studio⏳ These are partial results; builds are still running. This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push. |
Greptile SummaryThe PR synchronizes currency-specific account, beneficiary, external-account, and payment-instruction schemas, including new ILS support. The ILS payment-instructions branch is currently unsatisfiable because the shared payment-account enum was not extended with
Confidence Score: 4/5The PR should not merge until The new ILS payment schema requires Files Needing Attention: openapi/components/schemas/common/PaymentAccountType.yaml, openapi/components/schemas/common/PaymentInstructions.yaml, openapi.yaml, mintlify/openapi.yaml
|
| Filename | Overview |
|---|---|
| openapi/components/schemas/common/PaymentInstructions.yaml | Adds the ILS union branch, but that branch cannot validate because its inherited account-type constraints conflict. |
| openapi/components/schemas/common/PaymentIlsAccountInfo.yaml | Combines the shared payment-account base and ILS account schema, exposing the conflicting accountType enums. |
| openapi/components/schemas/common/PaymentAccountType.yaml | Remains synchronized without ILS_ACCOUNT, making the newly added ILS payment-instructions schema unsatisfiable. |
| openapi/components/schemas/external_accounts/ExternalAccountCreateInfoOneOf.yaml | Adds the ILS external-account creation variant and discriminator mapping consistently. |
| openapi.yaml | The assembled contract reproduces the unsatisfiable ILS payment-instructions branch. |
| mintlify/openapi.yaml | The documentation contract reproduces the same conflicting ILS payment-account constraints. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
PI[PaymentInstructions] --> ILS[PaymentIlsAccountInfo]
ILS --> BASE[BasePaymentAccountInfo]
ILS --> INFO[IlsAccountInfo]
BASE --> ENUM["PaymentAccountType<br/>excludes ILS_ACCOUNT"]
INFO --> VALUE["accountType = ILS_ACCOUNT"]
ENUM --> CONFLICT[Unsatisfiable allOf]
VALUE --> CONFLICT
Prompt To Fix All With AI
### Issue 1
openapi/components/schemas/common/PaymentInstructions.yaml:56
**ILS account type conflict**
When payment instructions contain `accountType: ILS_ACCOUNT`, `PaymentIlsAccountInfo` requires that value while its inherited `PaymentAccountType` enum excludes it, causing every ILS payment-instructions payload to fail schema validation and preventing generated clients from representing this new variant.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "chore: Sync account schemas" | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| - $ref: ../common/PaymentSlvAccountInfo.yaml | ||
| - $ref: ../common/PaymentSwiftAccountInfo.yaml | ||
| - $ref: ../common/PaymentCnyAccountInfo.yaml | ||
| - $ref: ../common/PaymentIlsAccountInfo.yaml |
There was a problem hiding this comment.
When payment instructions contain accountType: ILS_ACCOUNT, PaymentIlsAccountInfo requires that value while its inherited PaymentAccountType enum excludes it, causing every ILS payment-instructions payload to fail schema validation and preventing generated clients from representing this new variant.
Knowledge Base Used: Grid API contract
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/PaymentInstructions.yaml
Line: 56
Comment:
**ILS account type conflict**
When payment instructions contain `accountType: ILS_ACCOUNT`, `PaymentIlsAccountInfo` requires that value while its inherited `PaymentAccountType` enum excludes it, causing every ILS payment-instructions payload to fail schema validation and preventing generated clients from representing this new variant.
**Knowledge Base Used:** [Grid API contract](https://app.greptile.com/lightspark/-/custom-context/knowledge-base/lightsparkdev/grid-api/-/docs/api-contract.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Auto-synced account schemas.
These schemas are generated from VASP adapter field definitions in sparkcore.
Synced schemas:
common/— per-currency account info, beneficiary, and payment account schemascommon/PaymentInstructions.yaml— payment instructions oneOf (new currencies added)external_accounts/— per-currency external account schemas (reference common/)Please review the changes before merging.