Skip to content

chore: Sync account schemas #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lightspark-copybara wants to merge 1 commit into from
Closed

chore: Sync account schemas #885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mintlify/openapi.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions openapi.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions openapi/components/schemas/common/PhpAccountInfoBase.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ properties:
description: Name of the beneficiary's bank
minLength: 1
maxLength: 255
example: BDO Unibank
example: Bank of the Philippine Islands (BPI)

@greptile-apps greptile-apps Bot Sep 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Generated PHP examples drift

The wallet field generators copy this updated example from the OpenAPI schema, but the committed production and demo artifacts still contain BDO Unibank. Regenerate both artifacts so the wallets display the same PHP bank example as the published contract and verify:bank-fields does not produce a diff.

Knowledge Base Used: Grid API contract

Prompt To Fix With AI 
This is a comment left during a code review.
Path: openapi/components/schemas/common/PhpAccountInfoBase.yaml
Line: 23

Comment:
**Generated PHP examples drift**

The wallet field generators copy this updated example from the OpenAPI schema, but the committed production and demo artifacts still contain `BDO Unibank`. Regenerate both artifacts so the wallets display the same PHP bank example as the published contract and `verify:bank-fields` does not produce a diff.

**Knowledge Base Used:** [Grid API contract](https://app.greptile.com/lightspark/-/custom-context/knowledge-base/lightsparkdev/grid-api/-/docs/api-contract.md)

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

accountNumber:
type: string
description: Bank account number
Expand All @@ -31,5 +31,5 @@ properties:
example:
accountType: PHP_ACCOUNT
rail: INSTAPAY
bankName: BDO Unibank
bankName: Bank of the Philippine Islands (BPI)
accountNumber: '001234567890'
Loading