chore: Sync account schemas - #886
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
✱ Stainless preview builds for gridThis PR will update the cli go kotlin openapi php python ruby typescript Edit this comment to update them. They will appear in their respective SDK's changelogs. ✅ grid-typescript studio · code · diff
✅ grid-openapi studio · code · diff
✅ grid-ruby studio · code · diff
✅ grid-kotlin studio · code · diff
✅ grid-go studio · code · diff
✅ grid-python studio · code · diff
✅ grid-php studio · code · diff
✅ grid-cli studio · code · diff
This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push. |
Greptile SummaryThis PR updates the PHP account schema’s bank-name example from BDO Unibank to Bank of the Philippine Islands and synchronizes both assembled OpenAPI contracts.
Confidence Score: 4/5The generated bank-field artifacts should be synchronized before merging so verification passes and wallet examples do not remain stale. The OpenAPI source and bundles agree, but the changed example feeds checked-in generated wallet data that still contains the old value. Files Needing Attention: openapi/components/schemas/common/PhpAccountInfoBase.yaml and generated wallet bank-field artifacts
|
| Filename | Overview |
|---|---|
| openapi/components/schemas/common/PhpAccountInfoBase.yaml | Updates the PHP bank-name example, but dependent generated wallet artifacts were not regenerated. |
| openapi.yaml | Keeps the assembled root contract synchronized with the modular schema change. |
| mintlify/openapi.yaml | Keeps the Mintlify contract synchronized with the modular schema change. |
Prompt To Fix All With AI
### Issue 1
openapi/components/schemas/common/PhpAccountInfoBase.yaml:23
**Generated bank fields are stale**
When bank-field verification regenerates artifacts from this changed OpenAPI example, the output differs from the checked-in demo and production files, causing verification to fail and leaving wallet examples on the old `BDO Unibank` value.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "chore: Sync account schemas" | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| minLength: 1 | ||
| maxLength: 255 | ||
| example: BDO Unibank | ||
| example: Bank of the Philippine Islands (BPI) |
There was a problem hiding this comment.
When bank-field verification regenerates artifacts from this changed OpenAPI example, the output differs from the checked-in demo and production files, causing verification to fail and leaving wallet examples on the old BDO Unibank value.
Context Used: CLAUDE.md (source)
Knowledge Base Used: Grid API contract
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/PhpAccountInfoBase.yaml
Line: 23
Comment:
**Generated bank fields are stale**
When bank-field verification regenerates artifacts from this changed OpenAPI example, the output differs from the checked-in demo and production files, causing verification to fail and leaving wallet examples on the old `BDO Unibank` value.
**Context Used:** CLAUDE.md ([source](https://github.com/lightsparkdev/grid-api/blob/main/CLAUDE.md))
**Knowledge Base Used:** [Grid API contract](https://app.greptile.com/lightspark/-/custom-context/knowledge-base/lightsparkdev/grid-api/-/docs/api-contract.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Auto-synced account schemas.
These schemas are generated from VASP adapter field definitions in sparkcore.
Synced schemas:
common/— per-currency account info, beneficiary, and payment account schemascommon/PaymentInstructions.yaml— payment instructions oneOf (new currencies added)external_accounts/— per-currency external account schemas (reference common/)mintlify/snippets/corridor-required-fields.mdx— per-corridor required fields tablemintlify/corridor-fields.js— filter script for that tablePlease review the changes before merging.