Repository navigation
Support OpenTelemetry configuration options #127
Description
Is your feature request related to a problem? Please describe.
OpenTelemetry has a list of supported configurations that the LS Launcher is missing. Example:
DB statement sanitization: https://opentelemetry.io/docs/instrumentation/java/automatic/agent-config/#db-statement-sanitization
Describe the solution you'd like
Support all available config options for the OpenTelemetry agent.
Reacted by Greg Deane and patpatpat123
Reacted by Greg Deane
Activity
gregdeane commentedon Jun 27, 2022
+1
carlosalberto commentedon Jun 27, 2022
Hey hey - all these configuration should work just fine. The Java Launcher simply pre-configures some parameters (e.g. OTLP ingestion path, OTLP headers), but anything else works fine and transparently. Are you having a specific problem or a use case is not working as expected?
jenni commentedon Jun 28, 2022
@carlosalberto I can't log the
dbattributes in Lightstep.OTEL_INSTRUMENTATION_COMMON_DB_STATEMENT_SANITIZER_ENABLED=falseenv var., I could still see?.-Dotel.instrumentation.common.db-statement-sanitizer.enabled=false, did not work, same?.otel.instrumentation.common.db-statement-sanitizer.enabledin theapplication.propertiesfile, did not work, same?.I took a quick look to the project. [I might be missing something essential but...] it seems that some Opentelemetry configs are not read by the VariablesConverter class, so the agent is always configured with the default values, in this particular example:
OTEL_INSTRUMENTATION_COMMON_DB_STATEMENT_SANITIZER_ENABLED=truecarlosalberto commentedon Jun 28, 2022
Interesting. Variables converter pre-sets some values, but properties should flow transparently. Will take a second look to double check what's going on.
jenni commentedon Jul 7, 2022
@carlosalberto any news on this?:)
codeboten commentedon Aug 5, 2022
Hi @jenni! Apologies for the delay here, @carlosalberto is coming back from PTO next week and will follow up here.
jenni commentedon Aug 19, 2022
@codeboten @carlosalberto it's a pity that it's been 2 months since I opened this issue and haven't heard back from anyone. I have tried to look into it myself but I can't start the project as some environment variables are missing and there's no documentation on how to contribute here. I guess the best would be to add some docs or simply deprecate the repo.