Repository navigation
fix(docs): run /work/out inside container in README Docker (CI) quickstart (#1831) - #1846
Open
harmweber787-png wants to merge 1 commit into
Conversation
harmweber787-png
force-pushed
the
fix/issue-1831-docker-quickstart-sh-c
branch
from
October 31, 2026 22:03
323ca0b to
273103f
Compare
harmweber787-png
force-pushed
the
fix/issue-1831-docker-quickstart-sh-c
branch
from
November 1, 2026 04:17
273103f to
9cb43b0
Compare
Contributor
|
Shepherd W2 could not update this branch automatically (behind main by 1007). Labeled |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1831
Problem
In
README.md(## Docker (CI), lines 155–157),&& /work/outwas placed unquoted afterdocker run ... hyb build ./program.hy -o /work/out, so the host shell parsed&&and tried to execute/work/outon the host machine (where/workdoes not exist and where the container'slinux/amd64ELF binary cannot run on macOS/Windows hosts).Fix
sh -c 'hyb build ./program.hy -o /work/out && /work/out'inREADME.mdso bothhyb buildand/work/outexecute inside the container where/workis mounted.test_readme_docker_quickstart_runs_output_inside_container) intools/test_check_versions.pyverifying that the## Docker (CI)command passessh -c 'hyb build ./program.hy -o /work/out && /work/out'todockerrather than chaining/work/outon the host shell.Verification
python3 -m unittest discover -s tools -p test_check_versions.py -v(16/16 pass)python3 tools/check_test_registration.py(OK)