Skip to content

fix(docs): run /work/out inside container in README Docker (CI) quickstart (#1831) - #1846

Open
harmweber787-png wants to merge 1 commit into
limitlessprojects:mainfrom
harmweber787-png:fix/issue-1831-docker-quickstart-sh-c
Open

harmweber787-png wants to merge 1 commit into
limitlessprojects:mainfrom
harmweber787-png:fix/issue-1831-docker-quickstart-sh-c

Conversation

@harmweber787-png

Copy link
Copy Markdown

Fixes #1831

Problem

In README.md (## Docker (CI), lines 155–157), && /work/out was placed unquoted after docker run ... hyb build ./program.hy -o /work/out, so the host shell parsed && and tried to execute /work/out on the host machine (where /work does not exist and where the container's linux/amd64 ELF binary cannot run on macOS/Windows hosts).

Fix

  • Wrap the container command in sh -c 'hyb build ./program.hy -o /work/out && /work/out' in README.md so both hyb build and /work/out execute inside the container where /work is mounted.
  • Add a regression test (test_readme_docker_quickstart_runs_output_inside_container) in tools/test_check_versions.py verifying that the ## Docker (CI) command passes sh -c 'hyb build ./program.hy -o /work/out && /work/out' to docker rather than chaining /work/out on the host shell.

Verification

  • python3 -m unittest discover -s tools -p test_check_versions.py -v (16/16 pass)
  • python3 tools/check_test_registration.py (OK)

@github-actions github-actions Bot added the bot:land-candidate Shepherd: fresh, gate-clean, verifiable (set from classify()) label Oct 26, 2026
@github-actions github-actions Bot added the bot:stale-base Shepherd: behind main beyond threshold label Oct 30, 2026
@harmweber787-png
harmweber787-png force-pushed the fix/issue-1831-docker-quickstart-sh-c branch from 323ca0b to 273103f Compare October 31, 2026 22:03
@harmweber787-png
harmweber787-png force-pushed the fix/issue-1831-docker-quickstart-sh-c branch from 273103f to 9cb43b0 Compare November 1, 2026 04:17
@github-actions github-actions Bot added the bot:conflict Shepherd: merge conflicts vs main label Nov 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Shepherd W2 could not update this branch automatically (behind main by 1007). Labeled bot:conflict — if the conflicts are docs-only (PLAN.md/STATUS.md) W5 resolves them deterministically; otherwise this needs a human.

PUT /repos/limitlessprojects/Go-Hybrid/pulls/1846/update-branch -> 403 {"message":"refusing to allow a GitHub App to create or update workflow `.github/workflows/ci.yml` without `workflows` permission","documentation_url":"https://docs.github.com/rest/pulls/pulls#update-a-pull-request-branch","status":"403"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:conflict Shepherd: merge conflicts vs main bot:land-candidate Shepherd: fresh, gate-clean, verifiable (set from classify()) bot:stale-base Shepherd: behind main beyond threshold

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: Docker quickstart executes /work/out on the host

1 participant