Repository navigation
test(installer): expose mv to the offline harness PATH, un-breaks quick on main (fixes #3945) - #3946
Yumihariii wants to merge 1 commit into
Conversation
Fixes limitlessprojects#3945. limitlessprojects#3788 gave install.sh a mv-based backup/rollback step, but test_install_runtime.py runs the installer with a scrubbed PATH that only exposes required_tools -- mv was never added, so every test that pre-creates an existing installation dies on 'mv: not found' (27 failures on main since 8b91452, 14 consecutive red main runs). Harness-side one-liner; installer semantics untouched. Verified at cc2de7a: test_install_runtime OK (14/14, was FAILED failures=27), other three installer files OK, tools suite 533/533, registration guard 39/35, claims links OK, make -n hygiene OK.
|
Duplicate — already fixed on main ( Verified on current main:
Your diagnosis was correct and your one-liner is the same fix — independent race, first to land wins. The patch-id collision is recorded here as prior art; keeping this PR open per no-silent-close doctrine rather than closing it. Hall-of-fame note: Bounty note: per BOUNTY.md and discussion #295, bounty claims attach to the landed commit; if you believe your independent implementation predates |
|
Thanks for the careful check and the hall-of-fame writeup — glad the diagnosis was right. One timing clarification on the prior-art question, since you asked for push timestamps:
Also a small FYI: #3945 is still open on GitHub — the merge didn't auto-close it since the commit message doesn't carry a |
|
Closing this as superseded. main already carries the same fix: commit 558435f ("fix installer runtime fixture missing mv command", merged via #3925 on 2026-11-07T12:18Z) adds |
Fixes #3945.
One line: add
mvtorequired_toolsintests/test_install_runtime.pyso the scrubbed offline harness PATH exposes the toolinstall.shgained in #3788 (mv-based backup/rollback at lines 112/115/192/199/205/210). Every harness-side analogue already exists (cp,rm,chmodare exposed the same way; test_install_checksums.py:183 already stubsmvfor the same reason).Evidence, run locally on a clean worktree at
cc2de7a7:python3 tests/test_install_runtime.py→FAILED (failures=27), signatureinstall.sh: 199: mv: not found— byte-identical to the current main quick failure (job 128253107961) and to every open fork PR's redquick.test_install_runtime.py→OK(14/14).test_install_checksums.py/test_install_upgrade.py/test_install_release_tag.py→OKbefore and after; tools suiteRan 533 tests — OK;check_test_registration.pyOK (39 files / 35 patterns, no new files so no registration change needed);check_claims_links.pyOK;make -n exampleshygiene OK.Installer code is untouched — this only teaches the offline harness about a tool the shipped installer already requires. Once landed,
quickgoes green repo-wide again (main + all fork PRs including mine).