Repository navigation
tools/shepherd: bind W7 always() session-log verdicts to job.status - #4500
Open
romanfjose wants to merge 1 commit into
Open
romanfjose wants to merge 1 commit into
romanfjose wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
.github/workflows/shepherd-board.yml,.github/workflows/shepherd-dup.yml, and.github/workflows/shepherd-rebase.yml, the finalW7 session logstep executes underif: always()with static completion claims (--verdict "ok" --note "board + labels refreshed",--note "phase A/B pass complete",--note "rebase shepherd tick").When an earlier step fails or is cancelled???as observed live on
main(b1627e8) inshepherd-boardrun43752174585, whereScanexited1andRewrite board/Sync tier labelswere skipped???W7 session logstill runs and writesverdict: "ok"+"board + labels refreshed"intologs/SESSION.jsonl.Changes
tools/shepherd.py:resolve_log_outcome(verdict, note, job_status=None)and--job-statusonshepherd.py log.--job-statusis omitted."ok"+ completionnotewhen--job-statusis"success".--job-statusis non-"success"("failure","cancelled", etc.), recordingverdict=<status>andnote="job <status> before completion (intended: <note>)"..github/workflows/shepherd-{board,dup,rebase}.yml:if: always()W7 session logsteps to--verdict "ok"and--job-status "${{ job.status }}".tools/test_shepherd_gate.py:W7LogOutcomeTests(4 unit tests coveringsuccess,failure,cancelled, and omittedjob_status).WorkflowWorkspacePaths.test_always_w7_session_logs_bind_job_statusscanning.github/workflows/shepherd-*.ymlso noif: always()session-log step can omit--job-status "${{ job.status }}".Verification
Fixes #4499