chore: require PHP 8.4 and z-engine ~8.4.0 - #11
Merged
Conversation
The library still targeted PHP 7.4/8.0 with z-engine 0.8/0.9. The class extension hook API it relies on (write-property, get-property-pointer, unset-property, interface-gets-implemented) is unchanged in z-engine 8.4, so no source changes are needed - only the platform pins: - composer: php ~8.4.0, lisachenko/z-engine ~8.4.0, explicit ext-ffi, phpunit ^12 - phpunit.xml.dist: migrate to the current schema (filter/whitelist and logging sections are gone) - CI: run on PHP 8.4 with ffi enabled and JIT off (lowest + highest deps), validate the manifest, drop the xdebug coverage run - README: bump the advertised PHP requirement All 8 phpt functional tests pass on PHP 8.4.19 with both dependency sets. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HRDZ2XsoVuB5uG4qXKL3ny
…ctions - replace phpunit.yml with ci.yml: a validate/lint gate (composer validate --strict, php -l over src and tests) followed by the test matrix (PHP 8.4, lowest + highest dependency sets, FFI on, JIT off) - dependabot: keep the daily composer updates and add weekly github-actions updates so action pins stay current Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HRDZ2XsoVuB5uG4qXKL3ny
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings immutable-object onto the same z-engine 8.4 baseline as the other dependent repos (php-shared-data-extension#13, userland-php-generics#12), and modernizes the repo automation.
The library still targeted PHP 7.4/8.0 with z-engine
^0.8.1|^0.9.1. The class-extension hook API it relies on (WritePropertyHook,GetPropertyPointerHook,UnsetPropertyHook,InterfaceGetsImplementedHook,ObjectCreateTrait) is unchanged in z-engine 8.4, so no source changes are needed — only the platform pins and tooling:php ~8.4.0,lisachenko/z-engine ~8.4.0, explicitext-ffi, PHPUnit^12filter/whitelistandloggingsections no longer exist in PHPUnit 12)phpunit.ymlreplaced with a fullci.ymlpipeline — a validate/lint gate (composer validate --strict,php -loversrcandtests) followed by the test matrix on PHP 8.4 with FFI enabled and JIT off, covering lowest + highest dependency sets; drops the old PHP 7.4/8.0 xdebug matrixgithub-actionsupdates so action pins stay currentVerified locally on PHP 8.4.19: all 8 phpt functional tests pass with both
--prefer-lowestand highest dependency sets against z-engine 8.4.0.Note: unlike the shared-data extension, this library is not affected by the z-engine 8.4.0
pointerAtAddress()leak (lisachenko/z-engine#135) — it makes no per-call pointer lookups — so CI here does not need to wait for the 8.4.1 tag.