LiveKitAPI entrypoint, ability to use a token instead of api key/secret#695
Open
davidzhao wants to merge 5 commits into
Open
LiveKitAPI entrypoint, ability to use a token instead of api key/secret#695davidzhao wants to merge 5 commits into
davidzhao wants to merge 5 commits into
Conversation
- added a LiveKitAPI class to reduce overhead of accessing services - ability to use token based auth instead of requiring API key/secret - comprehensive api testing - added SIPCallError
🦋 Changeset detectedLatest commit: 9d4c580 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
The generated src/version.ts tripped the REUSE license check (no SPDX header) and Prettier, and committing it isn't the repo convention — livekit-rtc gitignores its generated version.ts. Gitignore and prettier-ignore it, untrack it, and have the Test API workflow run `prebuild` to generate it before the tests (the main CI test job already builds first, which generates it). Also fix import ordering in TwirpRPC.test.ts. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
LiveKitAPI fell back to process.env.LIVEKIT_TOKEN unconditionally, so a token in the environment silently shadowed an explicitly passed apiKey/secret (authHeader sends a token verbatim, skipping signing). Only fall back to LIVEKIT_TOKEN when no explicit credentials were given, and add a regression test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.