fix wait_for_playout finishing too early#270
Merged
Merged
Conversation
davidzhao
approved these changes
Oct 1, 2024
chenghao-mou
added a commit
to livekit/node-sdks
that referenced
this pull request
Jul 1, 2026
Discard the waiter when released (timer, clearQueue, close) and lazily re-create it on the next captureFrame, matching python-sdks' fix for the same bug (livekit/python-sdks#270). Releasing also cancels the drain timer so an orphaned timer can't release a later segment's waiter. waitForPlayout() now resolves immediately when no audio is queued, matching Python semantics. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
chenghao-mou
added a commit
to livekit/node-sdks
that referenced
this pull request
Jul 2, 2026
…ed (#693) * fix: AudioSource.waitForPlayout resolving early with audio still queued The internal playout promise could be left resolved (latched) by the drain timer firing during a gap between captures, or by clearQueue(). A later waitForPlayout() then consumed the stale resolution and reported playout complete with up to queueSizeMs of audio still buffered, clipping the tail of agent speech on every turn downstream. Re-arm the promise on the next captureFrame when it was already released, and skip the post-playout bookkeeping reset when the promise was re-armed while waiting. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * refactor: mirror python-sdks _release_waiter structure Discard the waiter when released (timer, clearQueue, close) and lazily re-create it on the next captureFrame, matching python-sdks' fix for the same bug (livekit/python-sdks#270). Releasing also cancels the drain timer so an orphaned timer can't release a later segment's waiter. waitForPlayout() now resolves immediately when no audio is queued, matching Python semantics. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.