consistent error class ServerError, test suite#744
Conversation
ServerError is now the error base class. we've also kept TwirpError as an alias. also added full api smoke test suite
davidzhao
requested review from
cloudwebrtc,
lukasIO and
xianshijing-lk
as code owners
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| client_timeout = aiohttp.ClientTimeout( | ||
| total=timeout if timeout else DEFAULT_RINGING_TIMEOUT | ||
| ) |
There was a problem hiding this comment.
🚩 accept_whatsapp_call timeout lacks the RINGING_TIMEOUT_MARGIN used by SIP service
The accept_whatsapp_call method uses DEFAULT_RINGING_TIMEOUT (30s) as the request timeout when wait_until_answered is set, without adding RINGING_TIMEOUT_MARGIN (2s). In contrast, the SIP service's create_sip_participant uses ring + RINGING_TIMEOUT_MARGIN to ensure the HTTP request outlasts the ringing window. If the server takes exactly 30s to ring, the connector request could time out at the boundary. This is pre-existing behavior (unchanged by this PR) but the inconsistency is worth noting since the PR cleaned up the DialRequest union that previously included AcceptWhatsAppCallRequest.
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
ServerError is now the error base class. we've also kept TwirpError as an alias.
also added full api smoke test suite