smite: move ChannelTypeVariant to bolt::types - #234
Open
NishantBansal2003 wants to merge 1 commit into
Open
Conversation
The `accept_channel` oracle needs to verify that `channel_type` uses the smallest possible bitmap and represents a defined channel type. Keeping `ChannelTypeVariant` in `bolt::types` gives the oracle a canonical set of channel types to validate against and avoids duplicating the definition across modules. Signed-off-by: Nishant Bansal <nishant.bansal.282003@gmail.com>
|
The refactor preserves everything besides the newly added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
accept_channeloracle needs to verify thatchannel_typeuses the smallest possible bitmap and represents a defined channel type. KeepingChannelTypeVariantinbolt::typesgives the oracle a canonical set of channel types to validate against and avoids duplicating the definition across modules.This commit was part of #209, but I thought of separating some of the code-move changes to keep the diff smaller. So this is mostly a code-move change with a few small code changes